Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Specify deephaven-plugin-utilities version for pre-commit #898

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

mattrunyon
Copy link
Collaborator

Looks like pre-commit uses its own venv if you specify dependencies, so this version needs to be explicit. Otherwise our local pre-commit hooks will have old dependencies and fail locally

@mattrunyon mattrunyon requested a review from mofojed September 19, 2024 22:48
@mattrunyon mattrunyon self-assigned this Sep 19, 2024
@mattrunyon mattrunyon enabled auto-merge (squash) September 19, 2024 22:50
@mattrunyon mattrunyon disabled auto-merge September 19, 2024 22:50
@mattrunyon mattrunyon changed the title fix: Specify deephaven-plugin-utilities version for pre-commit ci: Specify deephaven-plugin-utilities version for pre-commit Sep 19, 2024
@mattrunyon mattrunyon enabled auto-merge (squash) September 19, 2024 22:51
@mattrunyon mattrunyon merged commit fa83c28 into deephaven:main Sep 19, 2024
11 checks passed
wusteven815 pushed a commit to wusteven815/deephaven-plugins that referenced this pull request Sep 24, 2024
…ven#898)

Looks like pre-commit uses its own venv if you specify dependencies, so
this version needs to be explicit. Otherwise our local pre-commit hooks
will have old dependencies and fail locally
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants