-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: separate jobs for unit and integration tests #102
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 11034137945Details
💛 - Coveralls |
anakin87
changed the title
separate integration test
ci: separate jobs for unit and integration tests
Sep 25, 2024
anakin87
requested review from
julian-risch and
shadeMe
and removed request for
a team and
julian-risch
September 25, 2024 13:32
anakin87
commented
Sep 25, 2024
shadeMe
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
unit-tests
jobHow did you test it?
CI
Notes for the reviewer
With this PR, integration tests depend on the
linting
job.We can make different choices, but this seemed reasonable to me to avoid long running times.
I also experimented with cache (with an approach similar to that used in Haystack). Still, I encountered some issues and I also found out that restoring the cache is slow in some environments (Windows), so I decided to avoid it for the time being.
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.