Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: separate jobs for unit and integration tests #102

Merged
merged 21 commits into from
Sep 26, 2024

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 commented Sep 25, 2024

Related Issues

Proposed Changes:

  • run only unit tests in the existing unit-tests job
  • create a similar job for integration tests

How did you test it?

CI

Notes for the reviewer

With this PR, integration tests depend on the linting job.
We can make different choices, but this seemed reasonable to me to avoid long running times.

I also experimented with cache (with an approach similar to that used in Haystack). Still, I encountered some issues and I also found out that restoring the cache is slow in some environments (Windows), so I decided to avoid it for the time being.

Checklist

@coveralls
Copy link

coveralls commented Sep 25, 2024

Pull Request Test Coverage Report for Build 11034137945

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-3.7%) to 90.272%

Totals Coverage Status
Change from base Build 11029532546: -3.7%
Covered Lines: 1429
Relevant Lines: 1583

💛 - Coveralls

@anakin87 anakin87 changed the title separate integration test ci: separate jobs for unit and integration tests Sep 25, 2024
@anakin87 anakin87 marked this pull request as ready for review September 25, 2024 13:32
@anakin87 anakin87 requested a review from a team as a code owner September 25, 2024 13:32
@anakin87 anakin87 requested review from julian-risch and shadeMe and removed request for a team and julian-risch September 25, 2024 13:32
@anakin87 anakin87 merged commit 0e669c2 into main Sep 26, 2024
15 checks passed
@anakin87 anakin87 deleted the separate-integration-tests branch September 26, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI test work flow should separate unit and integration steps
3 participants