feat: create requests #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xkenj1
reviewed
Sep 16, 2024
Comment on lines
10
to
14
| export type Epoch = { | ||
| epoch: bigint; | ||
| epochFirstBlockNumber: bigint; | ||
| epochStartTimestamp: Timestamp; | ||
| }; |
There was a problem hiding this comment.
Suggested change
| export type Epoch = { | |
| epoch: bigint; | |
| epochFirstBlockNumber: bigint; | |
| epochStartTimestamp: Timestamp; | |
| }; | |
| export type Epoch = { | |
| count: bigint; | |
| firstBlockNumber: bigint; | |
| startTimestamp: Timestamp; | |
| }; |
What do you think if we do it this way. I noticed some places that u did Epoch["epoch"] and i think Epoch["count"] or Epoch["number"] might be more descriptive and cleaner.
There was a problem hiding this comment.
Ended up using number, on the basis of having epoch.number and also block.number. count feels a little bit more like there are elements inside the Epoch
jahabeebs
previously approved these changes
Sep 16, 2024
| @@ -53,6 +54,8 @@ const EBO_EVENT_COMPARATOR = (e1: EboEvent<EboEventName>, e2: EboEvent<EboEventN | |||
| return e1.logIndex - e2.logIndex; | |||
| }; | |||
|
|
|||
| export type ActorRequest = { id: RequestId; epoch: bigint; chainId: Caip2ChainId }; | |||
There was a problem hiding this comment.
Not sure if you meant to put this in types file?
| import { RequestId } from "../types/prophet.js"; | ||
| import { EboActor } from "./eboActor.js"; | ||
| import { RequestId } from "../types/index.js"; | ||
| import { ActorRequest, EboActor } from "./eboActor.js"; |
There was a problem hiding this comment.
Yeah maybe the types should be moved and imported from index.js since we're using them in a couple files
0xkenj1
approved these changes
Sep 16, 2024
jahabeebs
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Linear
Closes GRT-171
Description
Epochtype created