-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create requests #42
Merged
Merged
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
3fdb86f
refactor: define Epoch type
0xyaco fb2e843
feat: spawn new actors during new epochs
0xyaco e77f764
fix: improve actor termination checks
0xyaco 52b6a9a
fix: logs messages
0xyaco a3fb435
chore: remove feature's TODO comment
0xyaco 2aade37
refactor: rename epoch properties
0xyaco 88f0201
Merge remote-tracking branch 'origin/dev' into feat/spawn-agents
0xyaco File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,8 +4,8 @@ import { Mutex } from "async-mutex"; | |
|
||
import { RequestAlreadyHandled } from "../exceptions/index.js"; | ||
import { ProtocolProvider } from "../providers/protocolProvider.js"; | ||
import { RequestId } from "../types/prophet.js"; | ||
import { EboActor } from "./eboActor.js"; | ||
import { RequestId } from "../types/index.js"; | ||
import { ActorRequest, EboActor } from "./eboActor.js"; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah maybe the types should be moved and imported from index.js since we're using them in a couple files |
||
import { EboMemoryRegistry } from "./eboRegistry/eboMemoryRegistry.js"; | ||
|
||
export class EboActorsManager { | ||
|
@@ -21,7 +21,11 @@ export class EboActorsManager { | |
* @returns array of normalized request IDs | ||
*/ | ||
public getRequestIds(): RequestId[] { | ||
return [...this.requestActorMap.entries()].map((entry) => Address.normalize(entry[0])); | ||
return [...this.requestActorMap.keys()].map((requestId) => Address.normalize(requestId)); | ||
} | ||
|
||
public getActorsRequests(): ActorRequest[] { | ||
return [...this.requestActorMap.values()].map((actor) => actor.actorRequest); | ||
} | ||
|
||
/** | ||
|
@@ -30,10 +34,7 @@ export class EboActorsManager { | |
* @param actor an `EboActor` instance that handles a request. | ||
*/ | ||
public createActor( | ||
actorRequest: { | ||
id: RequestId; | ||
epoch: bigint; | ||
}, | ||
actorRequest: ActorRequest, | ||
protocolProvider: ProtocolProvider, | ||
blockNumberService: BlockNumberService, | ||
logger: ILogger, | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if you meant to put this in types file?