Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-11597 remove CC pagination flipper #34246

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

randimays
Copy link
Contributor

@randimays randimays commented Jan 23, 2025

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

⚠️ TeamSites ⚠️

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

Remove facility_locator_restore_community_care_pagination flipper. It is on in staging and production, but the only logic that uses it checks if it is off.

Flipper admin in staging and prod:
Screenshot 2025-01-23 at 5 08 53 PM

Related issue(s)

department-of-veterans-affairs/va.gov-cms#11597

Testing & screenshots

Checked CC provider search in local vs. prod - same behavior:

Local

Screenshot 2025-01-23 at 5 16 23 PM Screenshot 2025-01-23 at 5 16 32 PM

Prod

Screenshot 2025-01-23 at 5 16 43 PM Screenshot 2025-01-23 at 5 16 51 PM

LocationType.URGENT_CARE_PHARMACIES,
LocationType.EMERGENCY_CARE,
].includes(state.searchQuery.facilityType) &&
!facilityLocatorRestoreCommunityCarePagination(state)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the only logic using this feature flipper checks to see if it is OFF, but it is ON in staging and production, and presumably has been for a while.

Copy link
Contributor

@chriskim2311 chriskim2311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants