Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-11597 remove CC pagination flipper #34246

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -2,20 +2,19 @@
import React, { Component } from 'react';
import { connect } from 'react-redux';
import { LocationType } from '../constants';
import { facilityLocatorRestoreCommunityCarePagination } from '../utils/featureFlagSelectors';

export class PaginationWrapper extends Component {
shouldComponentUpdate = nextProps =>
nextProps.results !== this.props.results ||

Check warning on line 8 in src/applications/facility-locator/components/PaginationWrapper.jsx

View workflow job for this annotation

GitHub Actions / Linting (Files Changed)

src/applications/facility-locator/components/PaginationWrapper.jsx:8:15:'results' is missing in props validation

Check warning on line 8 in src/applications/facility-locator/components/PaginationWrapper.jsx

View workflow job for this annotation

GitHub Actions / Linting (Files Changed)

src/applications/facility-locator/components/PaginationWrapper.jsx:8:38:'results' is missing in props validation

Check warning on line 8 in src/applications/facility-locator/components/PaginationWrapper.jsx

View workflow job for this annotation

GitHub Actions / Linting (Files Changed)

src/applications/facility-locator/components/PaginationWrapper.jsx:8:15:'results' is missing in props validation

Check warning on line 8 in src/applications/facility-locator/components/PaginationWrapper.jsx

View workflow job for this annotation

GitHub Actions / Linting (Files Changed)

src/applications/facility-locator/components/PaginationWrapper.jsx:8:38:'results' is missing in props validation
nextProps.inProgress !== this.props.inProgress;

Check warning on line 9 in src/applications/facility-locator/components/PaginationWrapper.jsx

View workflow job for this annotation

GitHub Actions / Linting (Files Changed)

src/applications/facility-locator/components/PaginationWrapper.jsx:9:15:'inProgress' is missing in props validation

Check warning on line 9 in src/applications/facility-locator/components/PaginationWrapper.jsx

View workflow job for this annotation

GitHub Actions / Linting (Files Changed)

src/applications/facility-locator/components/PaginationWrapper.jsx:9:41:'inProgress' is missing in props validation

Check warning on line 9 in src/applications/facility-locator/components/PaginationWrapper.jsx

View workflow job for this annotation

GitHub Actions / Linting (Files Changed)

src/applications/facility-locator/components/PaginationWrapper.jsx:9:15:'inProgress' is missing in props validation

Check warning on line 9 in src/applications/facility-locator/components/PaginationWrapper.jsx

View workflow job for this annotation

GitHub Actions / Linting (Files Changed)

src/applications/facility-locator/components/PaginationWrapper.jsx:9:41:'inProgress' is missing in props validation

render() {
const {
shouldRender,

Check warning on line 13 in src/applications/facility-locator/components/PaginationWrapper.jsx

View workflow job for this annotation

GitHub Actions / Linting (Files Changed)

src/applications/facility-locator/components/PaginationWrapper.jsx:13:7:'shouldRender' is missing in props validation

Check warning on line 13 in src/applications/facility-locator/components/PaginationWrapper.jsx

View workflow job for this annotation

GitHub Actions / Linting (Files Changed)

src/applications/facility-locator/components/PaginationWrapper.jsx:13:7:'shouldRender' is missing in props validation
handlePageSelect,

Check warning on line 14 in src/applications/facility-locator/components/PaginationWrapper.jsx

View workflow job for this annotation

GitHub Actions / Linting (Files Changed)

src/applications/facility-locator/components/PaginationWrapper.jsx:14:7:'handlePageSelect' is missing in props validation

Check warning on line 14 in src/applications/facility-locator/components/PaginationWrapper.jsx

View workflow job for this annotation

GitHub Actions / Linting (Files Changed)

src/applications/facility-locator/components/PaginationWrapper.jsx:14:7:'handlePageSelect' is missing in props validation
currentPage,

Check warning on line 15 in src/applications/facility-locator/components/PaginationWrapper.jsx

View workflow job for this annotation

GitHub Actions / Linting (Files Changed)

src/applications/facility-locator/components/PaginationWrapper.jsx:15:7:'currentPage' is missing in props validation

Check warning on line 15 in src/applications/facility-locator/components/PaginationWrapper.jsx

View workflow job for this annotation

GitHub Actions / Linting (Files Changed)

src/applications/facility-locator/components/PaginationWrapper.jsx:15:7:'currentPage' is missing in props validation
totalPages,

Check warning on line 16 in src/applications/facility-locator/components/PaginationWrapper.jsx

View workflow job for this annotation

GitHub Actions / Linting (Files Changed)

src/applications/facility-locator/components/PaginationWrapper.jsx:16:7:'totalPages' is missing in props validation

Check warning on line 16 in src/applications/facility-locator/components/PaginationWrapper.jsx

View workflow job for this annotation

GitHub Actions / Linting (Files Changed)

src/applications/facility-locator/components/PaginationWrapper.jsx:16:7:'totalPages' is missing in props validation
results,

Check warning on line 17 in src/applications/facility-locator/components/PaginationWrapper.jsx

View workflow job for this annotation

GitHub Actions / Linting (Files Changed)

src/applications/facility-locator/components/PaginationWrapper.jsx:17:7:'results' is missing in props validation

Check warning on line 17 in src/applications/facility-locator/components/PaginationWrapper.jsx

View workflow job for this annotation

GitHub Actions / Linting (Files Changed)

src/applications/facility-locator/components/PaginationWrapper.jsx:17:7:'results' is missing in props validation
} = this.props;

if (
Expand All @@ -23,7 +22,7 @@
currentPage &&
totalPages > 1 &&
results &&
results.length > 0

Check warning on line 25 in src/applications/facility-locator/components/PaginationWrapper.jsx

View workflow job for this annotation

GitHub Actions / Linting (Files Changed)

src/applications/facility-locator/components/PaginationWrapper.jsx:25:15:'results.length' is missing in props validation

Check warning on line 25 in src/applications/facility-locator/components/PaginationWrapper.jsx

View workflow job for this annotation

GitHub Actions / Linting (Files Changed)

src/applications/facility-locator/components/PaginationWrapper.jsx:25:15:'results.length' is missing in props validation
) {
return (
<VaPagination
Expand All @@ -41,17 +40,6 @@
const mapStateToProps = state => {
let shouldHidePagination = false;

if (
[
LocationType.CC_PROVIDER,
LocationType.URGENT_CARE_PHARMACIES,
LocationType.EMERGENCY_CARE,
].includes(state.searchQuery.facilityType) &&
!facilityLocatorRestoreCommunityCarePagination(state)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the only logic using this feature flipper checks to see if it is OFF, but it is ON in staging and production, and presumably has been for a while.

) {
shouldHidePagination = true;
}

// pagination not yet supported for PPMS urgent care
if (
state.searchQuery.facilityType === LocationType.URGENT_CARE &&
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,3 @@ export const facilityLocatorShowOperationalHoursSpecialInstructions = state =>

export const facilityLocatorLatLongOnly = state =>
toggleValues(state)[FEATURE_FLAG_NAMES.facilityLocatorLatLongOnly];

export const facilityLocatorRestoreCommunityCarePagination = state =>
toggleValues(state)[
FEATURE_FLAG_NAMES.facilityLocatorRestoreCommunityCarePagination
];
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@
"facilityLocatorLatLongOnly": "facility_locator_lat_long_only",
"facilityLocatorPredictiveLocationSearch": "facility_locator_predictive_location_search",
"facilityLocatorRailsEngine": "facility_locator_rails_engine",
"facilityLocatorRestoreCommunityCarePagination": "facility_locator_restore_community_care_pagination",
"facilityLocatorShowCommunityCares": "facility_locator_show_community_cares",
"facilityLocatorShowHealthConnectNumber": "facility_locator_show_health_connect_number",
"facilityLocatorShowOperationalHoursSpecialInstructions": "facility_locator_show_operational_hours_special_instructions",
Expand Down
Loading