Update component-library to v49.0.0 #34404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rsmithadhoc
commented
Jan 30, 2025
•
rsmithadhoc
commented
- Update library versions
- CSS-Library: Update uswds tokens in vets-website on next release vets-design-system-documentation#3756 Updates tokens away from the USWDS primitive versions
- Fix test selectors.
- Fix PACT Act tests.
- We have had issues with the PACT Act tests before. It originally checked for error not visible, then visible but no text, and now some error spans don't even exist. So I just added a new function to check for that case and trial/error to find the ones that needed the check. It definitely won't bulletproof the tests, but I'm just working with what is there.
va-vfs-bot
temporarily deployed
to
master/component-library-release-v49.0.0/main
micahchiang
previously approved these changes
Jan 30, 2025
va-vfs-bot
temporarily deployed
to
master/component-library-release-v49.0.0/main
va-vfs-bot
temporarily deployed
to
master/component-library-release-v49.0.0/main
va-vfs-bot
temporarily deployed
to
master/component-library-release-v49.0.0/main
randimays
approved these changes
Jan 31, 2025
micahchiang
approved these changes
Jan 31, 2025
micahchiang
added a commit
that referenced
this pull request
Jan 31, 2025
This reverts commit ab015fb.
micahchiang
added a commit
that referenced
this pull request
Feb 1, 2025
* Revert "Update component-library to v49.0.0 (#34404)" This reverts commit ab015fb. * update css vars Signed-off-by: Micah Chiang <[email protected]> * skipping flaky tests for now Signed-off-by: Micah Chiang <[email protected]> --------- Signed-off-by: Micah Chiang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.