Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm Specs Update #221

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Helm Specs Update #221

merged 2 commits into from
Mar 11, 2024

Conversation

Jdubrick
Copy link
Contributor

@Jdubrick Jdubrick commented Mar 8, 2024

Please specify the area for this PR

What does does this PR do / why we need it:
This PR alters the timeout values so that the Helm deployment and operator deployment are synced in their values. Additionally it removes the env file mounts as the variables are defined in the spec and it is un-needed. This PR also updates the pod level security context to match that of the operator.

Which issue(s) this PR fixes:

fixes devfile/api#1430

PR acceptance criteria:

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?

Documentation (WIP)

How to test changes / Special notes to the reviewer:
Deployed Helm chart on both minikube and openshift and verified the security context was applied properly and deployment was successful.

@openshift-ci openshift-ci bot requested a review from elsony March 8, 2024 20:08
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2024
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.23%. Comparing base (ffc3a09) to head (00df100).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #221   +/-   ##
=======================================
  Coverage   27.23%   27.23%           
=======================================
  Files           7        7           
  Lines        2012     2012           
=======================================
  Hits          548      548           
  Misses       1417     1417           
  Partials       47       47           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Trying helm chart deployment works in my environment ✔️

Noticed that the viewer-env-file was not removed from the configmap,yaml template, however this is also the case in the operator so this state is synced. Should open an issue to address the lingering configmap entry in both the helm chart and registry operator.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2024
Copy link

openshift-ci bot commented Mar 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jdubrick, michael-valdron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Jdubrick,michael-valdron]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Jdubrick
Copy link
Contributor Author

/lgtm

Trying helm chart deployment works in my environment ✔️

Noticed that the viewer-env-file was not removed from the configmap,yaml template, however this is also the case in the operator so this state is synced. Should open an issue to address the lingering configmap entry in both the helm chart and registry operator.

@michael-valdron sounds good, I'll open a new issue for removing the env file from both operator and Helm chart.

@Jdubrick Jdubrick merged commit 6215550 into devfile:main Mar 11, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement changes in deployment specification under devfile registry helm chart
2 participants