-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helm Specs Update #221
Helm Specs Update #221
Conversation
Signed-off-by: Jordan Dubrick <[email protected]>
Signed-off-by: Jordan Dubrick <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #221 +/- ##
=======================================
Coverage 27.23% 27.23%
=======================================
Files 7 7
Lines 2012 2012
=======================================
Hits 548 548
Misses 1417 1417
Partials 47 47 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Trying helm chart deployment works in my environment ✔️
Noticed that the viewer-env-file
was not removed from the configmap,yaml
template, however this is also the case in the operator so this state is synced. Should open an issue to address the lingering configmap entry in both the helm chart and registry operator.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jdubrick, michael-valdron The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@michael-valdron sounds good, I'll open a new issue for removing the env file from both operator and Helm chart. |
Please specify the area for this PR
What does does this PR do / why we need it:
This PR alters the timeout values so that the Helm deployment and operator deployment are synced in their values. Additionally it removes the env file mounts as the variables are defined in the spec and it is un-needed. This PR also updates the pod level security context to match that of the operator.
Which issue(s) this PR fixes:
fixes devfile/api#1430
PR acceptance criteria:
Documentation (WIP)
How to test changes / Special notes to the reviewer:
Deployed Helm chart on both minikube and openshift and verified the security context was applied properly and deployment was successful.