-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ginkgo skip jhipster-online #508
Conversation
Hi @maximilianoPizarro. Thanks for your PR. I'm waiting for a devfile member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
fe36bd6
to
e4c6160
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, I'm just checking why the odo 3 check fails. I'm sure is not related with the current PR. I'll give it a bit of time till I re-run it if it fails again. I see the nightly run didn't exit for the same reason.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
I think the failure in CI is related to the mirror url, it might just be down currently
yeah I suspect so too. I guess let's give it some time |
/retest |
Bug reported failing check: devfile/api#1656 |
/retest |
@maximilianoPizarro Suggest a rebase, if the updated Red Hat Konflux check fails we can bypass it for this PR. |
Signed-off-by: Maximiliano Pizarro <[email protected]>
e4c6160
to
fd2693a
Compare
Signed-off-by: Maximiliano Pizarro <[email protected]>
Signed-off-by: Maximiliano Pizarro <[email protected]>
fd2693a
to
92a789a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Hi @michael-valdron again. Container test exited with code 1, reason Error
---
led
+ for test in '"${FAILED_TESTS[@]}"'
+ echo 'name: nodejs-nuxtjs version: 1.0.3 error: create failed'
name: nodejs-nuxtjs version: 1.0.3 error: create failed
+ for test in '"${FAILED_TESTS[@]}"'
+ echo 'name: nodejs-nuxtjs version: 1.1.0 error: create failed'
name: nodejs-nuxtjs version: 1.1.0 error: create failed
+ for test in '"${FAILED_TESTS[@]}"'
+ echo 'name: nodejs-react version: 2.0.2 error: unable to get working url'
name: nodejs-react version: 2.0.2 error: unable to get working url
+ for test in '"${FAILED_TESTS[@]}"'
+ echo 'name: nodejs-react version: 2.1.0 error: unable to get working url'
name: nodejs-react version: 2.1.0 error: unable to get working url
+ for test in '"${FAILED_TESTS[@]}"'
+ echo 'name: nodejs-svelte version: 1.0.3 error: unable to get working url'
name: nodejs-svelte version: 1.0.3 error: unable to get working url
+ for test in '"${FAILED_TESTS[@]}"'
+ echo 'name: nodejs-svelte version: 1.1.0 error: unable to get working url'
name: nodejs-svelte version: 1.1.0 error: unable to get working url
+ for test in '"${FAILED_TESTS[@]}"'
+ echo 'name: nodejs-vue version: 1.0.2 error: unable to get working url'
name: nodejs-vue version: 1.0.2 error: unable to get working url
+ for test in '"${FAILED_TESTS[@]}"'
+ echo 'name: nodejs-vue version: 1.1.0 error: unable to get working url'
name: nodejs-vue version: 1.1.0 error: unable to get working url
+ for test in '"${FAILED_TESTS[@]}"'
+ echo 'name: php-laravel version: 1.0.1 error: create failed'
name: php-laravel version: 1.0.1 error: create failed
+ for test in '"${FAILED_TESTS[@]}"'
+ echo 'name: python version: 2.1.0 error: create failed'
name: python version: 2.1.0 error: create failed
+ exit 1 Would you like me to add them to the ginkgo skip list in this PR? |
@maximilianoPizarro Thanks for offering but not necessary, these failures are caused by an issue with our testing environment: devfile/api#1663 Also another issue regarding other stacks using the 2.2.2 spec by default but not being exempt from the odo v2 testing that our integration testing uses. For your PR, I can run our integration testing locally for you tomorrow and bypass the failing check if everything passes as nothing I am seeing is being cause by your changes. |
/retest |
@maximilianoPizarro: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@maximilianoPizarro I was able to run your change successfully on my side: test_log.txt
All but the failures due to devfile/api#1664:
The following tests failed:
name: java-springboot version: 1.2.0 error: create failed
name: java-springboot version: 1.3.0 error: create failed
name: java-wildfly version: 1.1.0 error: create failed
name: nodejs version: 2.1.1 error: create failed
name: nodejs version: 2.2.0 error: create failed
name: nodejs-angular version: 2.0.2 error: create failed
name: nodejs-angular version: 2.1.0 error: create failed
name: nodejs-nextjs version: 1.0.3 error: create failed
name: nodejs-nextjs version: 1.1.0 error: create failed
name: nodejs-nuxtjs version: 1.0.3 error: create failed
name: nodejs-nuxtjs version: 1.1.0 error: create failed
name: php-laravel version: 1.0.1 error: create failed
name: python version: 2.1.0 error: create failed
name: java-maven version: 1.2.0 error: create failed
name: java-maven version: 1.3.0 error: create failed
name: java-vertx version: 1.2.0 error: create failed
name: java-vertx version: 1.3.0 error: create failed
Since these are unrelated to your change and this stack is not on this list I will bypass the protection to merge your PR.
@thepetk Does everything look good from your side?
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maximilianoPizarro, michael-valdron, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Yeah tbh I don't see any issues merging this PR |
Description of Changes
Only add --skip="stack: jhipster-online version: 2.23.0 starter: jhipster-online" from file tests/check_odov3.sh. Because fail in the step "with odo v3".
Example error in the last job:
https://github.com/devfile/registry/actions/runs/12200513685/job/34042081550
Summarizing 1 Failure:
[FAIL] test starter projects from devfile stacks [It] stack: jhipster-online version: 2.33.0 no_starter
/home/runner/work/registry/registry/tests/odov3/odo_test.go:192