Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ginkgo skip jhipster-online #508

Merged
merged 3 commits into from
Dec 20, 2024
Merged

Conversation

maximilianoPizarro
Copy link
Contributor

Description of Changes

Only add --skip="stack: jhipster-online version: 2.23.0 starter: jhipster-online" from file tests/check_odov3.sh. Because fail in the step "with odo v3".

Example error in the last job:

https://github.com/devfile/registry/actions/runs/12200513685/job/34042081550

Summarizing 1 Failure:
[FAIL] test starter projects from devfile stacks [It] stack: jhipster-online version: 2.33.0 no_starter
/home/runner/work/registry/registry/tests/odov3/odo_test.go:192

Copy link

openshift-ci bot commented Dec 9, 2024

Hi @maximilianoPizarro. Thanks for your PR.

I'm waiting for a devfile member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I'm just checking why the odo 3 check fails. I'm sure is not related with the current PR. I'll give it a bit of time till I re-run it if it fails again. I see the nightly run didn't exit for the same reason.

Copy link
Contributor

@Jdubrick Jdubrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

I think the failure in CI is related to the mirror url, it might just be down currently

@thepetk
Copy link
Contributor

thepetk commented Dec 9, 2024

/ok-to-test

I think the failure in CI is related to the mirror url, it might just be down currently

yeah I suspect so too. I guess let's give it some time

@michael-valdron michael-valdron mentioned this pull request Dec 9, 2024
4 tasks
@michael-valdron
Copy link
Member

/retest

@michael-valdron
Copy link
Member

Bug reported failing check: devfile/api#1656

@michael-valdron
Copy link
Member

/retest

@michael-valdron
Copy link
Member

@maximilianoPizarro Suggest a rebase, if the updated Red Hat Konflux check fails we can bypass it for this PR.

Signed-off-by: Maximiliano Pizarro <[email protected]>
tests/check_odov3.sh Outdated Show resolved Hide resolved
Signed-off-by: Maximiliano Pizarro <[email protected]>
Signed-off-by: Maximiliano Pizarro <[email protected]>
Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added lgtm Looks good to me approved labels Dec 18, 2024
@maximilianoPizarro
Copy link
Contributor Author

maximilianoPizarro commented Dec 18, 2024

Hi @michael-valdron again.
I see there are other projects that are affected.

Container test exited with code 1, reason Error
---
led
+ for test in '"${FAILED_TESTS[@]}"'
+ echo 'name: nodejs-nuxtjs version: 1.0.3 error: create failed'
name: nodejs-nuxtjs version: 1.0.3 error: create failed
+ for test in '"${FAILED_TESTS[@]}"'
+ echo 'name: nodejs-nuxtjs version: 1.1.0 error: create failed'
name: nodejs-nuxtjs version: 1.1.0 error: create failed
+ for test in '"${FAILED_TESTS[@]}"'
+ echo 'name: nodejs-react version: 2.0.2 error: unable to get working url'
name: nodejs-react version: 2.0.2 error: unable to get working url
+ for test in '"${FAILED_TESTS[@]}"'
+ echo 'name: nodejs-react version: 2.1.0 error: unable to get working url'
name: nodejs-react version: 2.1.0 error: unable to get working url
+ for test in '"${FAILED_TESTS[@]}"'
+ echo 'name: nodejs-svelte version: 1.0.3 error: unable to get working url'
name: nodejs-svelte version: 1.0.3 error: unable to get working url
+ for test in '"${FAILED_TESTS[@]}"'
+ echo 'name: nodejs-svelte version: 1.1.0 error: unable to get working url'
name: nodejs-svelte version: 1.1.0 error: unable to get working url
+ for test in '"${FAILED_TESTS[@]}"'
+ echo 'name: nodejs-vue version: 1.0.2 error: unable to get working url'
name: nodejs-vue version: 1.0.2 error: unable to get working url
+ for test in '"${FAILED_TESTS[@]}"'
+ echo 'name: nodejs-vue version: 1.1.0 error: unable to get working url'
name: nodejs-vue version: 1.1.0 error: unable to get working url
+ for test in '"${FAILED_TESTS[@]}"'
+ echo 'name: php-laravel version: 1.0.1 error: create failed'
name: php-laravel version: 1.0.1 error: create failed
+ for test in '"${FAILED_TESTS[@]}"'
+ echo 'name: python version: 2.1.0 error: create failed'
name: python version: 2.1.0 error: create failed
+ exit 1

Would you like me to add them to the ginkgo skip list in this PR?

@michael-valdron
Copy link
Member

Hi @michael-valdron again. I see there are other projects that are affected.

Container test exited with code 1, reason Error
---
led
+ for test in '"${FAILED_TESTS[@]}"'
+ echo 'name: nodejs-nuxtjs version: 1.0.3 error: create failed'
name: nodejs-nuxtjs version: 1.0.3 error: create failed
+ for test in '"${FAILED_TESTS[@]}"'
+ echo 'name: nodejs-nuxtjs version: 1.1.0 error: create failed'
name: nodejs-nuxtjs version: 1.1.0 error: create failed
+ for test in '"${FAILED_TESTS[@]}"'
+ echo 'name: nodejs-react version: 2.0.2 error: unable to get working url'
name: nodejs-react version: 2.0.2 error: unable to get working url
+ for test in '"${FAILED_TESTS[@]}"'
+ echo 'name: nodejs-react version: 2.1.0 error: unable to get working url'
name: nodejs-react version: 2.1.0 error: unable to get working url
+ for test in '"${FAILED_TESTS[@]}"'
+ echo 'name: nodejs-svelte version: 1.0.3 error: unable to get working url'
name: nodejs-svelte version: 1.0.3 error: unable to get working url
+ for test in '"${FAILED_TESTS[@]}"'
+ echo 'name: nodejs-svelte version: 1.1.0 error: unable to get working url'
name: nodejs-svelte version: 1.1.0 error: unable to get working url
+ for test in '"${FAILED_TESTS[@]}"'
+ echo 'name: nodejs-vue version: 1.0.2 error: unable to get working url'
name: nodejs-vue version: 1.0.2 error: unable to get working url
+ for test in '"${FAILED_TESTS[@]}"'
+ echo 'name: nodejs-vue version: 1.1.0 error: unable to get working url'
name: nodejs-vue version: 1.1.0 error: unable to get working url
+ for test in '"${FAILED_TESTS[@]}"'
+ echo 'name: php-laravel version: 1.0.1 error: create failed'
name: php-laravel version: 1.0.1 error: create failed
+ for test in '"${FAILED_TESTS[@]}"'
+ echo 'name: python version: 2.1.0 error: create failed'
name: python version: 2.1.0 error: create failed
+ exit 1

Would you like me to add them to the ginkgo skip list in this PR?

@maximilianoPizarro Thanks for offering but not necessary, these failures are caused by an issue with our testing environment: devfile/api#1663

Also another issue regarding other stacks using the 2.2.2 spec by default but not being exempt from the odo v2 testing that our integration testing uses.

For your PR, I can run our integration testing locally for you tomorrow and bypass the failing check if everything passes as nothing I am seeing is being cause by your changes.

@thepetk
Copy link
Contributor

thepetk commented Dec 19, 2024

/retest

Copy link

openshift-ci bot commented Dec 19, 2024

@maximilianoPizarro: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v4.15-registry-test 92a789a link true /test v4.15-registry-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@maximilianoPizarro I was able to run your change successfully on my side: test_log.txt

All but the failures due to devfile/api#1664:

The following tests failed:
name: java-springboot version: 1.2.0 error: create failed
name: java-springboot version: 1.3.0 error: create failed
name: java-wildfly version: 1.1.0 error: create failed
name: nodejs version: 2.1.1 error: create failed
name: nodejs version: 2.2.0 error: create failed
name: nodejs-angular version: 2.0.2 error: create failed
name: nodejs-angular version: 2.1.0 error: create failed
name: nodejs-nextjs version: 1.0.3 error: create failed
name: nodejs-nextjs version: 1.1.0 error: create failed
name: nodejs-nuxtjs version: 1.0.3 error: create failed
name: nodejs-nuxtjs version: 1.1.0 error: create failed
name: php-laravel version: 1.0.1 error: create failed
name: python version: 2.1.0 error: create failed
name: java-maven version: 1.2.0 error: create failed
name: java-maven version: 1.3.0 error: create failed
name: java-vertx version: 1.2.0 error: create failed
name: java-vertx version: 1.3.0 error: create failed

Since these are unrelated to your change and this stack is not on this list I will bypass the protection to merge your PR.

@thepetk Does everything look good from your side?

Copy link

openshift-ci bot commented Dec 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maximilianoPizarro, michael-valdron, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [michael-valdron,thepetk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thepetk
Copy link
Contributor

thepetk commented Dec 20, 2024

/lgtm

@maximilianoPizarro I was able to run your change successfully on my side: test_log.txt

All but the failures due to devfile/api#1664:

The following tests failed:
name: java-springboot version: 1.2.0 error: create failed
name: java-springboot version: 1.3.0 error: create failed
name: java-wildfly version: 1.1.0 error: create failed
name: nodejs version: 2.1.1 error: create failed
name: nodejs version: 2.2.0 error: create failed
name: nodejs-angular version: 2.0.2 error: create failed
name: nodejs-angular version: 2.1.0 error: create failed
name: nodejs-nextjs version: 1.0.3 error: create failed
name: nodejs-nextjs version: 1.1.0 error: create failed
name: nodejs-nuxtjs version: 1.0.3 error: create failed
name: nodejs-nuxtjs version: 1.1.0 error: create failed
name: php-laravel version: 1.0.1 error: create failed
name: python version: 2.1.0 error: create failed
name: java-maven version: 1.2.0 error: create failed
name: java-maven version: 1.3.0 error: create failed
name: java-vertx version: 1.2.0 error: create failed
name: java-vertx version: 1.3.0 error: create failed

Since these are unrelated to your change and this stack is not on this list I will bypass the protection to merge your PR.

@thepetk Does everything look good from your side?

Yeah tbh I don't see any issues merging this PR

@michael-valdron michael-valdron merged commit 136e079 into devfile:main Dec 20, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants