-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update events listeners for page specific scripts #1667
Draft
amitaibu
wants to merge
9
commits into
master
Choose a base branch
from
amitaibu-patch-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
51c58db
Update events listeners for page specific scripts
amitaibu 665d6ff
Remove ihp:load
amitaibu 9bff9a8
Add note about use of jQuery
amitaibu a6a6b03
Remove reference to ihpLoadEvent
amitaibu e00af15
Remove ihpUnloadEvent
amitaibu 8f1e327
Revert "Remove ihpUnloadEvent"
amitaibu 7e79bda
Revert "Remove reference to ihpLoadEvent"
amitaibu b5f59fb
Revert remove ihp:load
amitaibu 2fd1b5e
Add ihp:unload docs back
amitaibu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is a BC break, not sure whether that's worth it.
ihpLoadEvent
is also used somewhere in the file, so we'd need to remove the usages as well in case we want to delete these variablesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my tests I saw that
ihp:load
was not working as expected. So on the one hand it's BC break, but on the other - people using it might think it's working. Should we ask on Slack who's usingihp:load
, see if we get people to answer?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just checked and saw we're ourselves using this in several projects:
e.g. like this:
So let's keep this event here. But I'm fine with removing the outdated documentation on this and replacing it