remove [email protected] #33612
Merged
remove [email protected] #33612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jingcheng16
requested review from
millerdev,
dannyroberts,
biyeun and
gherceg
millerdev
reviewed
Oct 11, 2023
| @@ -477,7 +477,7 @@ | |||
| SUBSCRIPTION_CHANGE_EMAIL = '[email protected]' | |||
| INTERNAL_SUBSCRIPTION_CHANGE_EMAIL = '[email protected]' | |||
| BILLING_EMAIL = '[email protected]' | |||
| INVOICING_CONTACT_EMAIL = 'billing-support@example.com' | |||
| INVOICING_CONTACT_EMAIL = 'accounts@example.com' | |||
There was a problem hiding this comment.
This is @example.com, not @dimagi.com. Does it need to change?
There was a problem hiding this comment.
Hi Daniel, I want to keep this file a "mirror" for how we actually setup those email.
There was a problem hiding this comment.
Yeah, I agree, Jing. Since this is the generic commcare-hq settings.py file, we try and keep references to real dimagi email addresses out of it (so that third party instances' systems don't email us, for example!)
millerdev
approved these changes
Oct 13, 2023
biyeun
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical Summary
Ticket: https://dimagi-dev.atlassian.net/browse/SAAS-14988
Safety Assurance
Safety story
We will overwrite the localsettings in dimagi/commcare-cloud#6143
So I think there is no effects of changing the email here
Rollback instructions
Labels & Review