Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove [email protected] #33612

Merged
merged 1 commit into from
Oct 23, 2023
+1 −1
Merged

remove [email protected] #33612

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,7 +477,7 @@
SUBSCRIPTION_CHANGE_EMAIL = '[email protected]'
INTERNAL_SUBSCRIPTION_CHANGE_EMAIL = '[email protected]'
BILLING_EMAIL = '[email protected]'
INVOICING_CONTACT_EMAIL = 'billing-support@example.com'
INVOICING_CONTACT_EMAIL = 'accounts@example.com'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is @example.com, not @dimagi.com. Does it need to change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Daniel, I want to keep this file a "mirror" for how we actually setup those email.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I agree, Jing. Since this is the generic commcare-hq settings.py file, we try and keep references to real dimagi email addresses out of it (so that third party instances' systems don't email us, for example!)

GROWTH_EMAIL = '[email protected]'
MASTER_LIST_EMAIL = '[email protected]'
SALES_EMAIL = '[email protected]'
Expand Down
Loading