Entitlement: Update ends_at and starts_at to be nullable, not optional #7288
+12
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinloretz
requested review from
JustinBeckwith and
appellation
and removed request for
a team
colinloretz
changed the title
|
Why not stop sending fields as expected per documentation? |
Jiralite
reviewed
Nov 26, 2024
docs/resources/Entitlement.md
Outdated
Comment on lines
23
to
24
| | starts_at | ?ISO8601 timestamp | Start date at which the entitlement is valid. Not present when using test entitlements. | | ||
| | ends_at | ?ISO8601 timestamp | Date at which the entitlement is no longer valid. Not present when using test entitlements. | |
There was a problem hiding this comment.
Not present when using test entitlements.
I believe this should be amended if this is always present, or null, or otherwise?
There was a problem hiding this comment.
Correct, thank you! We should have updated these for the entitlement migration but they were missed.
JustinBeckwith
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7268