collector credential impedance mismatches #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves some impedance mismatches with the Janus aggregator API's handling of collector authentication tokens. Specifcally: - TaskCreate contains an `AuthenticationTokenHash`, which is not quite the same as an `AuthenticationToken` - The canonical form of a Janus bearer token is the unpadded Base64URL encoding of the bytes ([1]), and an authentication token hash is the SHA-256 of the canonical form (2). [1]: https://github.com/divviup/janus/blob/89a6a954339e526d991bab378fb5596d9eba64b8/core/src/auth_tokens.rs#L197 [2]: https://github.com/divviup/janus/blob/89a6a954339e526d991bab378fb5596d9eba64b8/core/src/auth_tokens.rs#L349
jbr
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves some impedance mismatches with the Janus aggregator API's handling of collector authentication tokens. Specifcally:
AuthenticationTokenHash, which is not quite the same as anAuthenticationToken