Adopt DAP-05 error types #1853
Merged
Adopt DAP-05 error types #1853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
tgeoghegan
force-pushed
the
timg/ping-pong
branch
from
90efb46 to
384ed5e
Compare
inahga
approved these changes
Sep 5, 2023
| async fn aggregation_job_init_wrong_query() { | ||
| let test_case = setup_aggregate_init_test().await; | ||
|
|
||
| // setup_aggregate_init_test sets up a task with a time interval query. We construct a |
There was a problem hiding this comment.
Incomplete comment here, might have lost some lines.
tgeoghegan
force-pushed
the
timg/ping-pong
branch
2 times, most recently
from
9e74231 to
a155d81
Compare
DAP-05 changes a few error types. `unrecongizedMessage -> invalidMessage` `queryMismatch` is gone (now we use `invalidMessage` in that case) `roundMismatch -> stepMismatch` We still use the word "round" in several places where "step" would be more appropriate given DAP-05 text. Renaming those variables, etc., will arrive in a later commit to avoid adding unnecessary noise here. Part of #1669
tgeoghegan
force-pushed
the
timg/dap-05-errors
branch
from
f00595d to
8ce3d7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DAP-05 changes a few error types.
unrecongizedMessage -> invalidMessagequeryMismatchis gone (now we useinvalidMessagein that case)roundMismatch -> stepMismatchWe still use the word "round" in several places where "step" would be more appropriate given DAP-05 text. Renaming those variables, etc., will arrive in a later commit to avoid adding unnecessary noise here.
Part of #1669