Integration/E2E test logging improvements #2011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Pass through the RUST_LOG environment variable to test containers, so we can directly control log level at the CLI. - Have each test deposit logs to a folder reflecting the test name, so that a logs from a test run that invoked multiple tests can be differentiated.
This is so that we can easily gather logs for cases that we think _should have_ failed, but didn't.
inahga
force-pushed
the
inahga/improve-logging
branch
from
0809b56 to
0b6b125
Compare
tgeoghegan
approved these changes
Sep 28, 2023
Co-authored-by: Tim Geoghegan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some improvements that came out of me debugging #1977.
infologging level.