Abandon collection jobs early when a fatal error is encountered #2476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgeoghegan
approved these changes
Jan 12, 2024
inahga
added a commit
that referenced
this pull request
Jan 12, 2024
inahga
added a commit
that referenced
this pull request
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets a collection job to immediately abandon on failure, except in a narrow set of retryable errors.
The
is_retryable_error()function is relatively narrow. It basically only retries on particular HTTP status codes and database errors. It's tricky to enumerate all possible retryable rrors. I'm welcome to input if there are other errors that should be retried.Note that it retries on 500 errors. I don't really want it to, but this is done to share the logic with the other HTTP retry logic we have. I will address whether we should generally retry on 500 errors in a future PR.
I will give the same treatment to aggregation jobs in another PR (see #235)