Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interests, social link and fix deployment. #36

Merged
merged 3 commits into from
Sep 15, 2018
Merged

Conversation

martinzlocha
Copy link
Member

@martinzlocha martinzlocha commented Aug 26, 2018

Description

Added new interests, social link when signing up and fixed hard-coded variables.

Also added issues #37 and #38 which arose during the process of making this PR.

Motivation and Context

Required to allow deploying this year and added to fill gaps in missing interests.

How Has This Been Tested?

Tested locally and by running test.sh

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the README document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sorry, something went wrong.

@martinzlocha martinzlocha requested a review from jackpordi August 26, 2018 09:30
@martinzlocha martinzlocha mentioned this pull request Aug 26, 2018
Copy link

@mauriceyap mauriceyap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eg. should be e.g. (feel free to ignore)

@martinzlocha martinzlocha merged commit e0f95a6 into master Sep 15, 2018
@martinzlocha martinzlocha deleted the 2018-update branch September 15, 2018 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants