Fix ugly line breaks in curly braces outside of page margin when using SciMLStyle
with yas_style_nesting=true
#785
+31
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On master, this
will be reformatted to this:
I modified
p_curly
ofYASStyle
to not always insert aPlaceholder(0)
but add aPlaceholder(1)
whenwhitespace_typedefs=true
. This is identical to what is done inDefaultStyle
. With this change, I can usep_curly
ofYASStyle
forSciMLStyle
as well whenyas_style_nesting=true
.Here is a demonstration of what happens in a large project when reformatted with this PR:
trixi-framework/Trixi.jl#1759
IMHO, many things get prettier, and everything else gets, well, at least not uglier
¯\_(ツ)_/¯
The only thing that gets slightly worse IMO is the file
src/solvers/dgmulti/sbp.jl
, but that wasn't pretty to begin with.