Issue 30288 small fixes #30289
Merged
Issue 30288 small fixes #30289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdotcms
reviewed
Oct 23, 2024
jdotcms
approved these changes
Oct 23, 2024
|
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
Open
jcastro-dotcms
approved these changes
Jan 8, 2025
…IRONMENTAL_VARIABLES` env var is not set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes across different files, focusing on updating health check paths, improving error handling, and removing outdated JSP files. The most important changes include modifying Kubernetes health check configurations, enhancing error handling in the
CMSFilterclass, and cleaning up old JSP files.Kubernetes Configuration Updates:
docker/k8s-aws-eks-manifest-examples/alb.yaml: Updated the health check path to/api/v1/alive.docker/k8s-aws-eks-manifest-examples/statefulset.yaml: Updated the startup, liveness, and readiness probe paths to/api/v1/heavyand/api/v1/light, and adjusted the failure threshold for liveness probes. [1] [2]Error Handling Improvements:
dotCMS/src/main/java/com/dotmarketing/filters/CMSFilter.java: Enhanced error handling to logClientAbortExceptionwithout throwing it again.Codebase Cleanup:
init.jsp,sub_nav.jsp,unlock_container.jsp,unlock_contentlet.jsp, andunlock_htmlpage.jsp. [1] [2] [3] [4] [5]Code Enhancements:
dotCMS/src/main/java/com/dotcms/rest/api/v1/maintenance/JVMInfoResource.java: Introduced a new patternobfuscateBasePatternfor obfuscating sensitive information and updated theobfuscateIfNeededmethod to use this new pattern. [1] [2]dotCMS/src/main/java/com/dotmarketing/portlets/languagesmanager/business/LanguageFactoryImpl.java: Improved thegetLanguagemethod to handle language IDs containing hyphens.dotCMS/src/main/java/com/dotmarketing/portlets/templates/business/TemplateFactoryImpl.java: Simplified SQL query to remove MS SQL-specific code.This PR fixes: #30288