Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 30288 small fixes #30289

Merged
merged 22 commits into from
Jan 10, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
d887391
task(k8) update example k8 manifests to use new endpoints
wezell Oct 8, 2024
1f4b84b
task(jsp) delete unused jsps
wezell Oct 8, 2024
20e6193
task(debt) delete unused MSSQL sql from TemplateFactoryImpl
wezell Oct 8, 2024
febbfee
task(logging) do not log ClientAbortException in CMSFilter
wezell Oct 8, 2024
9e98084
task(security) do not allow core config variable visibility to be cha…
wezell Oct 8, 2024
df53a41
task(lang) allow the LanguageFactory to support dashes, not just unde…
wezell Oct 8, 2024
2e72628
test(Util) add tests for NPE for functional UtilMethods.isSet(()->)
wezell Oct 8, 2024
7cacbe5
Merge branch 'main' into issue-30288-small-fixes
wezell Oct 8, 2024
af9146a
Merge branch 'main' into issue-30288-small-fixes
wezell Oct 8, 2024
e0e83bd
bug(apps) fixing link to dotAI portlet (#29556)
wezell Oct 9, 2024
73a8d34
Merge branch 'main' into issue-30288-small-fixes
wezell Oct 11, 2024
43baecc
Merge branch 'main' into issue-30288-small-fixes
wezell Oct 23, 2024
42a08c2
Merge branch 'main' into issue-30288-small-fixes
wezell Oct 29, 2024
1fb02d3
Merge branch 'main' into issue-30288-small-fixes
wezell Nov 7, 2024
4379c61
fix(lang) updating the isNumeric check
wezell Nov 7, 2024
0df437f
Merge branch 'main' into issue-30288-small-fixes
wezell Nov 8, 2024
6115944
Merge remote-tracking branch 'origin/master' into issue-30288-small-f…
wezell Nov 8, 2024
a063cec
fix(logs) reverting non-important changes so we can merge this thing …
wezell Nov 25, 2024
cbff338
Merge branch 'main' into issue-30288-small-fixes
wezell Dec 5, 2024
98bf468
Merge branch 'main' into issue-30288-small-fixes
dsilvam Jan 9, 2025
020788d
Return the `DEFAULT_OBFUSCATE_PATTERN` when the `OBFUSCATE_SYSTEM_ENV…
jcastro-dotcms Jan 9, 2025
72556ba
Merge branch 'main' into issue-30288-small-fixes
jcastro-dotcms Jan 9, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docker/k8s-aws-eks-manifest-examples/alb.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ metadata:
alb.ingress.kubernetes.io/backend-protocol: HTTP
alb.ingress.kubernetes.io/healthcheck-protocol: HTTP
alb.ingress.kubernetes.io/healthcheck-port: '8082'
alb.ingress.kubernetes.io/healthcheck-path: /api/v1/appconfiguration
alb.ingress.kubernetes.io/healthcheck-path: /api/v1/alive
alb.ingress.kubernetes.io/healthcheck-interval-seconds: '30'
alb.ingress.kubernetes.io/healthcheck-timeout-seconds: '5'
alb.ingress.kubernetes.io/success-codes: '200'
Expand Down
8 changes: 4 additions & 4 deletions docker/k8s-aws-eks-manifest-examples/statefulset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ spec:
fi; ln -s /data/shared/assets/.backup /data/local/dotsecure/backup;
startupProbe:
httpGet:
path: /api/v1/appconfiguration
path: /api/v1/heavy
port: 8082
initialDelaySeconds: 30
periodSeconds: 5
Expand All @@ -111,16 +111,16 @@ spec:
timeoutSeconds: 1
livenessProbe:
httpGet:
path: /api/v1/appconfiguration
path: /api/v1/light
port: 8082
initialDelaySeconds: 1
periodSeconds: 30
successThreshold: 1
failureThreshold: 1
failureThreshold: 3
timeoutSeconds: 10
readinessProbe:
httpGet:
path: /api/v1/appconfiguration
path: /api/v1/light
port: 8082
initialDelaySeconds: 1
periodSeconds: 10
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,16 @@
import com.dotmarketing.util.UtilMethods;
import com.liferay.portal.util.ReleaseInfo;
import io.vavr.control.Try;
import org.glassfish.jersey.server.JSONP;

import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
import javax.ws.rs.GET;
import javax.ws.rs.Path;
import javax.ws.rs.Produces;
import javax.ws.rs.core.Context;
import javax.ws.rs.core.MediaType;
import javax.ws.rs.core.Response;
import java.io.IOException;
import java.io.Serializable;
import java.lang.management.ManagementFactory;
Expand All @@ -20,23 +30,18 @@
import java.util.Map;
import java.util.Properties;
import java.util.regex.Pattern;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
import javax.ws.rs.GET;
import javax.ws.rs.Path;
import javax.ws.rs.Produces;
import javax.ws.rs.core.Context;
import javax.ws.rs.core.MediaType;
import javax.ws.rs.core.Response;
import org.glassfish.jersey.server.JSONP;


@Path("/v1/jvm")
@SuppressWarnings("serial")
public class JVMInfoResource implements Serializable {

private static final String DEFAULT_OBFUSCATE_PATTERN = "passw|pass|passwd|secret|key|token";

public static final Pattern obfuscateBasePattern = Pattern.compile(DEFAULT_OBFUSCATE_PATTERN,
Pattern.CASE_INSENSITIVE);

public static final Pattern obfuscatePattern = Pattern.compile(
Config.getStringProperty("OBFUSCATE_SYSTEM_ENVIRONMENTAL_VARIABLES", "passw|pass|passwd|secret|key|token"),
Config.getStringProperty("OBFUSCATE_SYSTEM_ENVIRONMENTAL_VARIABLES", DEFAULT_OBFUSCATE_PATTERN),
Pattern.CASE_INSENSITIVE);

@Path("/")
Expand Down Expand Up @@ -187,7 +192,9 @@ private Map<String,Object> getReleaseInfo(){
public static String obfuscateIfNeeded(final String key, final Object valueObject) {
final String value = (String) valueObject;
if(UtilMethods.isEmpty(value)) return "";
return obfuscatePattern.matcher(key).find() ? obfuscate(value) : value;
return obfuscateBasePattern.matcher(key).find() || obfuscatePattern.matcher(key).find()
? obfuscate(value)
: value;
}

private static String obfuscate(final String value) {
Expand Down
7 changes: 7 additions & 0 deletions dotCMS/src/main/java/com/dotmarketing/filters/CMSFilter.java
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,13 @@ public void doFilter(ServletRequest req, ServletResponse res, FilterChain chain)

try {
doFilterInternal(req, res, chain);
} catch (Exception e) {
if (e.getClass().getCanonicalName().contains("ClientAbortException")) {
wezell marked this conversation as resolved.
Show resolved Hide resolved
Logger.info(this.getClass(), "ClientAbortException: " + ((HttpServletRequest) req).getRequestURI());
Logger.debug(this.getClass(), "ClientAbortException: " + e.getMessage());
} else {
throw e;
}
} finally {
DbConnectionFactory.closeSilently();
}
Expand Down
27 changes: 0 additions & 27 deletions dotCMS/src/main/webapp/html/portlet/ext/director/init.jsp

This file was deleted.

2 changes: 0 additions & 2 deletions dotCMS/src/main/webapp/html/portlet/ext/director/sub_nav.jsp

This file was deleted.

108 changes: 0 additions & 108 deletions dotCMS/src/main/webapp/html/portlet/ext/director/unlock_container.jsp

This file was deleted.

138 changes: 0 additions & 138 deletions dotCMS/src/main/webapp/html/portlet/ext/director/unlock_contentlet.jsp

This file was deleted.

Loading
Loading