Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore query/fragment in ShouldMatch of NavLink by default but allow overriding ShouldMatch #59903

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
+133 −8

Revert previous approach, allow custom ShouldMatch implementations.

5a6caeb
Select commit
Loading
Failed to load commit list.
Open

Ignore query/fragment in ShouldMatch of NavLink by default but allow overriding ShouldMatch #59903

Revert previous approach, allow custom ShouldMatch implementations.
5a6caeb
Select commit
Loading
Failed to load commit list.
Azure Pipelines / aspnetcore-ci (Build Build: macOS x64) failed Jan 17, 2025 in 13m 16s

Build Build: macOS x64 failed

1 errors / 1 warnings

Annotations

Check failure on line 109 in src/Components/Web/src/Routing/NavLink.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / aspnetcore-ci (Build Build: macOS x64)

src/Components/Web/src/Routing/NavLink.cs#L109 

src/Components/Web/src/Routing/NavLink.cs(109,28): error CS1591: (NETCORE_ENGINEERING_TELEMETRY=Build) Missing XML comment for publicly visible type or member 'NavLink.ShouldMatch(string)'
View more details on Azure Pipelines