Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix markdown-link-check to run properly, fix JSON parse warning in CredScan #8325

Merged
merged 8 commits into from
Jul 18, 2022
Prev Previous commit
Next Next commit
More link fixes.
MiYanni committed Jul 16, 2022
commit b069979dfb15e2a6209592bd6cdc16eddc663bcf
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/branch-checklist.md
Original file line number Diff line number Diff line change
@@ -23,7 +23,7 @@ _Descriptions of these steps can be found in the team OneNote._
- [ ] Update the [signed build definition](https://devdiv.visualstudio.com/DevDiv/_build?definitionId=9675) to build the new branch
- [ ] Update Roslyn Tools [config.xml](https://github.com/dotnet/roslyn-tools/blob/main/src/GitHubCreateMergePRs/config.xml) file to flow branch changes to the latest dev branch
- [ ] dotnet/roslyn-tools PR: https://github.com/dotnet/roslyn-tools/pull/❓
- [ ] Update [Versions.props](..\..\build\import\Versions.props) (via `<ProjectSystemVersion>`) and [version.json](..\..\version.json) (via `"version"` and `"assemblyVersion"`) to match the version of VS, if needed
- [ ] Update [Versions.props](\..\..\build\import\Versions.props) (via `<ProjectSystemVersion>`) and [version.json](\..\..\version.json) (via `"version"` and `"assemblyVersion"`) to match the version of VS, if needed
- [ ] In new branch: https://github.com/dotnet/project-system/blob/dev17.❓.x/build/import/Versions.props
- [ ] In `main`: https://github.com/dotnet/project-system/blob/main/build/import/Versions.props
- [ ] Clone existing release definition to insert this branch into VS (see OneNote)
8 changes: 8 additions & 0 deletions .github/workflows/markdown-link-check-config.json
Original file line number Diff line number Diff line change
@@ -18,5 +18,13 @@
"pattern": "^/",
"replacement": "{{BASEURL}}/"
}
],
"httpHeaders": [
{
"urls": ["https://docs.github.com/"],
"headers": {
"Accept-Encoding": "zstd, br, gzip, deflate"
}
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Workaround for docs.github.com links. See: tcort/markdown-link-check#201 (comment)

]
}
4 changes: 2 additions & 2 deletions docs/repo/getting-started.md
Original file line number Diff line number Diff line change
@@ -3,13 +3,13 @@
#### Prerequisites
- [Visual Studio 16.3 Preview 2 or higher](https://visualstudio.microsoft.com/vs/preview/)
- GitHub account
- Basic Git experience: https://docs.github.com/en/get-started/quickstart/set-up-git
- Basic Git experience: https://docs.github.com/get-started/quickstart/set-up-git

All commands below are run under a [Visual Studio Developer Prompt](https://msdn.microsoft.com/en-us/library/ms229859(v=vs.150).aspx).

## Code

Contribution to this repository is via the [fork model](https://docs.github.com/en/get-started/quickstart/fork-a-repo). Contributors push changes to their own "forked" version of project-system, and then submit a pull request into it requesting those changes be merged.
Contribution to this repository is via the [fork model](https://docs.github.com/get-started/quickstart/fork-a-repo). Contributors push changes to their own "forked" version of project-system, and then submit a pull request into it requesting those changes be merged.

To get started: