-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix markdown-link-check to run properly, fix JSON parse warning in CredScan #8325
Changes from all commits
e3d9cc2
76ce07e
a7b101a
c34e249
2ccd8e2
b069979
2370f88
16afa27
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,30 @@ | ||
{ | ||
"ignorePatterns": [ | ||
{ | ||
"pattern": "^https://.*\.visualstudio\.com" | ||
"pattern": "^https:\/\/.*\\.visualstudio\\.com" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Backslash prior to the RegEx escaping backslash is required for JSON string encoding. |
||
}, | ||
{ | ||
"pattern": "^https:\/\/dev\\.azure\\.com" | ||
}, | ||
{ | ||
"pattern": "^https:\/\/aka\\.ms" | ||
}, | ||
{ | ||
"pattern": ".*❓.*" | ||
} | ||
], | ||
"replacementPatterns": [ | ||
{ | ||
"pattern": "^/", | ||
"replacement": "{{BASEURL}}/" | ||
} | ||
], | ||
"httpHeaders": [ | ||
{ | ||
"urls": ["https://docs.github.com/"], | ||
"headers": { | ||
"Accept-Encoding": "zstd, br, gzip, deflate" | ||
} | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Workaround for |
||
] | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,7 +3,7 @@ on: [push, pull_request] | |
|
||
jobs: | ||
markdown-link-check: | ||
name: verify | ||
name: markdown-link-check | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
runs-on: ubuntu-latest | ||
|
||
steps: | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,7 +8,7 @@ The .NET Core and ASP.NET Core support policy, including supported versions can | |
|
||
Security issues and bugs should be reported privately to the Microsoft Security Response Center (MSRC), either by emailing [email protected] or via the portal at https://msrc.microsoft.com. | ||
You should receive a response within 24 hours. If for some reason you do not, please follow up via email to ensure we received your | ||
original message. Further information, including the MSRC PGP key, can be found in the [MSRC Report an Issue FAQ](https://www.microsoft.com/en-us/msrc/faqs-report-an-issue). | ||
original message. Further information, including the MSRC PGP key, can be found in the [MSRC Report an Issue FAQ](https://www.microsoft.com/msrc/faqs-report-an-issue). | ||
|
||
Reports via MSRC may qualify for the .NET Core Bug Bounty. Details of the .NET Core Bug Bounty including terms and conditions are at [https://aka.ms/corebounty](https://aka.ms/corebounty). | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,8 +6,8 @@ | |
- *Potential change*: Rename this folder to `pipelines` as part of: https://github.com/dotnet/project-system/issues/7915 | ||
|
||
#### Notable Files | ||
- [official.yml](build\official.yml): This file is our official build pipeline that produces the signed packages (VSIX) that used for insertion into Visual Studio. | ||
- [unit-tests.yml](build\unit-tests.yml): This file is our build pipeline used when validating pull requests into the repo from GitHub. | ||
- [official.yml](ci\official.yml): This file is our official build pipeline that produces the signed packages (VSIX) that used for insertion into Visual Studio. | ||
- [unit-tests.yml](ci\unit-tests.yml): This file is our build pipeline used when validating pull requests into the repo from GitHub. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I take it this is fixing a broken link that is now being reported as broken? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
||
### `import` | ||
- This directory is highly accessed as part of the MSBuild pipeline to produce our assemblies, run tests, create packages, etc. | ||
|
@@ -22,7 +22,7 @@ | |
|
||
### `loc` | ||
- This directory contains the **OneLocBuildSetup** project which creates the `LocProject.json` and copies language-specific XLF files to become language-neutral; both of these are required for the [OneLocBuild](https://aka.ms/OneLocBuild) process for localization. | ||
- The **OneLocBuildSetup** project is only build and used as part of the [one-loc-build.yml](build\one-loc-build.yml) pipeline. | ||
- The **OneLocBuildSetup** project is only build and used as part of the [one-loc-build.yml](ci\one-loc-build.yml) pipeline. | ||
- *Potential change*: This pipeline might be combined into another pipeline as part of: https://github.com/dotnet/project-system/issues/7915 | ||
|
||
### `optprof` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See: tcort/markdown-link-check#215
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would
/
work instead?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would likely work, yes. However, I've made every local link in the repo use
\
. I'd have to go through and update all of them. I'll consider doing that at some point.