Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Copilot rename telemetry #76045

Merged

Conversation

AmadeusW
Copy link
Contributor

Update Copilot rename telemetry with the following information:

  • CorrelationID for correlation with Editor and Copilot telemetry. Defaults to empty GUID if not available (it will be available in 17.13 preview 2)
  • Time it took to get context
  • Whether context was used and whether there were any errors
    image

@AmadeusW AmadeusW requested a review from a team as a code owner November 23, 2024 00:01
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Nov 23, 2024
@dotnet-policy-service dotnet-policy-service bot added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Nov 23, 2024
@@ -93,6 +95,7 @@ private ISmartRenameSessionWrapper(object instance)
public string StatusMessage => s_statusMessageAccessor(_instance);
public bool StatusMessageVisibility => s_statusMessageVisibilityAccessor(_instance);
public IReadOnlyList<string> SuggestedNames => s_suggestedNamesAccessor(_instance);
public Guid CorrelationId => s_correlationIdAccessor(_instance);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we need to insert editor change first

@Cosifne
Copy link
Member

Cosifne commented Nov 25, 2024

Change looks good, but we might want to wait 17.13 P2 to merge this in

@AmadeusW
Copy link
Contributor Author

Thanks for the review. That's in line with my expectations, let's merge in December.

@Cosifne Cosifne merged commit 64aa047 into dotnet:main Dec 3, 2024
25 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee. untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants