Fix indexing of correlated diagnostic binaries #80652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 66af857 it looks like the runtime is not creating the clr <-> dac correlation index in symbol servers. `publishInstallersAndChecksums` is no longer needed, so skip passing that to the in-stage publish.
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsSince 66af857 it looks like the runtime is not creating the clr <-> dac correlation index in symbol servers.
|
ViktorHofer
approved these changes
Jan 17, 2023
|
Failure is #80666 |
mdh1418
pushed a commit
to mdh1418/runtime
that referenced
this pull request
Jan 24, 2023
Since dotnet@66af857 it looks like the runtime is not creating the clr <-> dac correlation index in symbol servers. `publishInstallersAndChecksums` is no longer needed, so skip passing that to the in-stage publish.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 66af857 it looks like the runtime is not creating the clr <-> dac correlation index in symbol servers.
publishInstallersAndChecksumsis no longer needed, so skip passing that to the in-stage publish.