Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0.2xx] Split GivenThatWeWantToRunILLink test class into multiple so Helix can run them separately #45056

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Backport of #44973 to release/9.0.2xx

/cc @joeloff @akoeplinger

@joeloff
Copy link
Member

joeloff commented Nov 23, 2024

Hmm, looks like we'll need to split off more tests based off the logs

@akoeplinger
Copy link
Member

not really, the log says

[Long Running Test] 'Microsoft.NET.Build.Tests.GivenThatWeWantToVerifyProjectReferenceCompat.Project_reference_compat', Elapsed: 00:59:49

so this one test took an hour i.e. it just hung.

@joeloff
Copy link
Member

joeloff commented Nov 24, 2024

not really, the log says

[Long Running Test] 'Microsoft.NET.Build.Tests.GivenThatWeWantToVerifyProjectReferenceCompat.Project_reference_compat', Elapsed: 00:59:49

so this one test took an hour i.e. it just hung.

I think it's just a really long running test. It tests compat across net45, 46 and every netstandard version from 1.0 through 2.0

@akoeplinger
Copy link
Member

the test normally takes just a couple minutes for all combinations, I've retried the build
image

@RikkiGibson
Copy link
Contributor

@joeloff is this ready to merge?

@joeloff
Copy link
Member

joeloff commented Dec 2, 2024

yeah, this was just a straight backport, but some branches are being locked for upcoming servicing builds. Let me double check to confirm

@joeloff joeloff merged commit 3090832 into release/9.0.2xx Dec 2, 2024
31 checks passed
@joeloff joeloff deleted the backport/pr-44973-to-release/9.0.2xx branch December 2, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-ILLink untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants