Remove AppTP Beta label in settings #3667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
This was referenced Oct 13, 2023
CrisBarreiro
force-pushed
the
feature/cbarreiro/remove-apptp-beta-label
branch
from
c49f48b to
47eaa00
Compare
This was referenced Oct 16, 2023
3 tasks
aitorvs
approved these changes
Nov 28, 2023
CrisBarreiro
force-pushed
the
feature/cbarreiro/remove-apptp-beta-label
branch
2 times, most recently
from
72236bd to
161075a
Compare
aitorvs
approved these changes
Dec 1, 2023
<!-- Note: This checklist is a reminder of our shared engineering expectations. The items in Bold are required If your PR involves UI changes: 1. Upload screenshots or screencasts that illustrate the changes before / after 2. Add them under the UI changes section (feel free to add more columns if needed) If your PR does not involve UI changes, you can remove the **UI changes** section At a minimum, make sure your changes are tested in API 23 and one of the more recent API levels available. --> Task/Issue URL: https://app.asana.com/0/0/1205217801169320/f Smartling job: https://dashboard.smartling.com/app/projects/b01b53ede/account-jobs/b01b53ede:xb9jhwltidzn?filter=ALL&projectIds[]=b01b53ede See title _Feature 1_ - [ ] Open AppTP settings - [ ] Go to my apps - [ ] Enable one of the apps that are disabled by default - [ ] Check the banner doesn't contain the word "Beta"  --------- Co-authored-by: Marcos Holgado <[email protected]>
<!-- Note: This checklist is a reminder of our shared engineering expectations. The items in Bold are required If your PR involves UI changes: 1. Upload screenshots or screencasts that illustrate the changes before / after 2. Add them under the UI changes section (feel free to add more columns if needed) If your PR does not involve UI changes, you can remove the **UI changes** section At a minimum, make sure your changes are tested in API 23 and one of the more recent API levels available. --> Task/Issue URL: https://app.asana.com/0/0/1205217801169319/f ### Description See title https://dashboard.smartling.com/app/projects/b01b53ede/account-jobs/b01b53ede:82gtdbvplyqu?filter=ALL ### Steps to test this PR _Feature 1_ - [x] Enable AppTP - [x] Go to AppTP main view - [x] Check the banner doesn't start with "During beta" ### UI changes | Before | After | | ------ | ----- | !(Upload before screenshot)|(Upload after screenshot)| --------- Co-authored-by: root <[email protected]>
CrisBarreiro
force-pushed
the
feature/cbarreiro/remove-apptp-beta-label
branch
from
e9838fe to
ade8c58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/72649045549333/1205884906775451/f
Description
Steps to test this PR
Feature 1
UI changes