Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix disabled state in Restore Protected Apps #3686

Merged
merged 2 commits into from
Oct 20, 2023
Merged

Fix disabled state in Restore Protected Apps #3686

merged 2 commits into from
Oct 20, 2023

Conversation

CrisBarreiro
Copy link
Contributor

@CrisBarreiro CrisBarreiro commented Oct 16, 2023 •
edited by marcosholgado
Loading

Task/Issue URL: https://app.asana.com/0/0/1205217801169326/f

Description

Steps to test this PR

Feature 1

  • Enable AppTP
  • Open View Apps
  • Click on the menu
  • Check restore option is grayed out if there were no changes to the app list

UI changes

restore
restorelight

This was referenced Oct 16, 2023
Merged
Merged
Closed
Merged
Merged
Merged
@CrisBarreiro
Copy link
Contributor Author

CrisBarreiro commented Oct 16, 2023 •
edited
Loading

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@CrisBarreiro CrisBarreiro mentioned this pull request Oct 16, 2023
Merged
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/restore-protected-apps-disabled branch from fabbb04 to 5cf5bc0 Compare October 16, 2023 11:53
marcosholgado
marcosholgado approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@marcosholgado marcosholgado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CrisBarreiro CrisBarreiro mentioned this pull request Oct 16, 2023
Merged
3 tasks
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/fix-touch-feedback branch from e8f8e7d to dda6546 Compare October 18, 2023 07:17
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/restore-protected-apps-disabled branch from 5cf5bc0 to 2b4fd72 Compare October 18, 2023 07:18
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/fix-touch-feedback branch from dda6546 to 97933b9 Compare October 18, 2023 14:32
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/restore-protected-apps-disabled branch from 2b4fd72 to 6e29b0d Compare October 18, 2023 14:32
@CrisBarreiro CrisBarreiro mentioned this pull request Oct 18, 2023
Merged
14 tasks
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/fix-touch-feedback branch from 97933b9 to a6be16a Compare October 19, 2023 11:20
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/restore-protected-apps-disabled branch from 6e29b0d to 7d4514f Compare October 19, 2023 11:20
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/fix-touch-feedback branch from a6be16a to 1e8c1f3 Compare October 19, 2023 11:56
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/restore-protected-apps-disabled branch from 7d4514f to 5ac1b68 Compare October 19, 2023 11:56
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/fix-touch-feedback branch from 1e8c1f3 to 2bdfc01 Compare October 19, 2023 11:57
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/restore-protected-apps-disabled branch from 5ac1b68 to df8513c Compare October 19, 2023 11:57
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/fix-touch-feedback branch from 2bdfc01 to 1eb84f5 Compare October 19, 2023 12:05
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/restore-protected-apps-disabled branch from df8513c to 2f559f8 Compare October 19, 2023 12:05
@CrisBarreiro
Fix shimmer layout from my apps (#3693)
c4abb09 
<!--
Note: This checklist is a reminder of our shared engineering
expectations.
The items in Bold are required
If your PR involves UI changes:
1. Upload screenshots or screencasts that illustrate the changes before
/ after
2. Add them under the UI changes section (feel free to add more columns
if needed)
If your PR does not involve UI changes, you can remove the **UI
changes** section

At a minimum, make sure your changes are tested in API 23 and one of the
more recent API levels available.
-->

Task/Issue URL: https://app.asana.com/0/0/1205217801169327/f 

### Description
See title

### Steps to test this PR

_Feature 1_
- [ ] Enable AppTP
- [ ] Open My Apps
- [ ] Check the shimmer layout shows several rows and not just a huge
one

### UI changes

![viewappscomp](https://github.com/duckduckgo/Android/assets/6297834/a8533f5e-295d-4222-badb-b92f0fc62935)
@CrisBarreiro CrisBarreiro merged commit a590d6d into feature/cbarreiro/fix-touch-feedback Oct 20, 2023
@CrisBarreiro CrisBarreiro deleted the feature/cbarreiro/restore-protected-apps-disabled branch October 20, 2023 10:06
@CrisBarreiro CrisBarreiro mentioned this pull request Oct 20, 2023
Merged
CrisBarreiro added a commit that referenced this pull request Nov 6, 2023
@CrisBarreiro
AppTP - minor UX improvements (#3668)
4bf1f70 
* **PR #3670** <a
href="https://app.graphite.dev/github/pr/duckduckgo/Android/3670"
target="_blank"><img
src="https://static.graphite.dev/graphite-32x32-black.png"
alt="Graphite" width="10px" height="10px"/></a>
* **PR #3671** <a
href="https://app.graphite.dev/github/pr/duckduckgo/Android/3671"
target="_blank"><img
src="https://static.graphite.dev/graphite-32x32-black.png"
alt="Graphite" width="10px" height="10px"/></a>
* **PR #3683** <a
href="https://app.graphite.dev/github/pr/duckduckgo/Android/3683"
target="_blank"><img
src="https://static.graphite.dev/graphite-32x32-black.png"
alt="Graphite" width="10px" height="10px"/></a>
* **PR #3684** <a
href="https://app.graphite.dev/github/pr/duckduckgo/Android/3684"
target="_blank"><img
src="https://static.graphite.dev/graphite-32x32-black.png"
alt="Graphite" width="10px" height="10px"/></a>
* **PR #3686** <a
href="https://app.graphite.dev/github/pr/duckduckgo/Android/3686"
target="_blank"><img
src="https://static.graphite.dev/graphite-32x32-black.png"
alt="Graphite" width="10px" height="10px"/></a>
* **PR #3693** <a
href="https://app.graphite.dev/github/pr/duckduckgo/Android/3693"
target="_blank"><img
src="https://static.graphite.dev/graphite-32x32-black.png"
alt="Graphite" width="10px" height="10px"/></a>
* **PR #3715** <a
href="https://app.graphite.dev/github/pr/duckduckgo/Android/3715"
target="_blank"><img
src="https://static.graphite.dev/graphite-32x32-black.png"
alt="Graphite" width="10px" height="10px"/></a>
* **PR #3732** <a
href="https://app.graphite.dev/github/pr/duckduckgo/Android/3732"
target="_blank"><img
src="https://static.graphite.dev/graphite-32x32-black.png"
alt="Graphite" width="10px" height="10px"/></a>
joshliebe pushed a commit that referenced this pull request Nov 7, 2023
@CrisBarreiro @joshliebe
AppTP - minor UX improvements (#3668)
915e1e6 
* **PR #3670** <a
href="https://app.graphite.dev/github/pr/duckduckgo/Android/3670"
target="_blank"><img
src="https://static.graphite.dev/graphite-32x32-black.png"
alt="Graphite" width="10px" height="10px"/></a>
* **PR #3671** <a
href="https://app.graphite.dev/github/pr/duckduckgo/Android/3671"
target="_blank"><img
src="https://static.graphite.dev/graphite-32x32-black.png"
alt="Graphite" width="10px" height="10px"/></a>
* **PR #3683** <a
href="https://app.graphite.dev/github/pr/duckduckgo/Android/3683"
target="_blank"><img
src="https://static.graphite.dev/graphite-32x32-black.png"
alt="Graphite" width="10px" height="10px"/></a>
* **PR #3684** <a
href="https://app.graphite.dev/github/pr/duckduckgo/Android/3684"
target="_blank"><img
src="https://static.graphite.dev/graphite-32x32-black.png"
alt="Graphite" width="10px" height="10px"/></a>
* **PR #3686** <a
href="https://app.graphite.dev/github/pr/duckduckgo/Android/3686"
target="_blank"><img
src="https://static.graphite.dev/graphite-32x32-black.png"
alt="Graphite" width="10px" height="10px"/></a>
* **PR #3693** <a
href="https://app.graphite.dev/github/pr/duckduckgo/Android/3693"
target="_blank"><img
src="https://static.graphite.dev/graphite-32x32-black.png"
alt="Graphite" width="10px" height="10px"/></a>
* **PR #3715** <a
href="https://app.graphite.dev/github/pr/duckduckgo/Android/3715"
target="_blank"><img
src="https://static.graphite.dev/graphite-32x32-black.png"
alt="Graphite" width="10px" height="10px"/></a>
* **PR #3732** <a
href="https://app.graphite.dev/github/pr/duckduckgo/Android/3732"
target="_blank"><img
src="https://static.graphite.dev/graphite-32x32-black.png"
alt="Graphite" width="10px" height="10px"/></a>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcosholgado marcosholgado marcosholgado approved these changes

Assignees

@marcosholgado marcosholgado

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CrisBarreiro @marcosholgado @malmstein @aitorvs