Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove backup service #4061

Merged
merged 4 commits into from
Jan 11, 2024
Merged

Conversation

nalcalag
Copy link
Contributor

@nalcalag nalcalag commented Jan 10, 2024

Task/Issue URL: https://app.asana.com/0/0/1206314482566716/f

Description

This PR contains the removal of the Google backup service implementation to persist ATB

Steps to test this PR

  • Go to develop
  • Add a file under the Android directory called test_d2d.sh
  • Copy and paste in this new file the code from https://app.asana.com/0/0/1206310480197408/f
  • Install from develop
  • Run ./test_cloud_backup.sh com.duckduckgo.mobile.android.debug to perform a backup
  • Check in File Explorer, you have com.duckduckgo.app.statistics.backup file with the atb key in it
  • Install from this branch
  • Refresh File Explorer
  • Check com.duckduckgo.app.statistics.backup has been cleared

No UI changes

@nalcalag
Copy link
Contributor Author

In this stack: 🔥 Streamline infrastructure by removing backup service

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @nalcalag and the rest of your teammates on Graphite Graphite

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kept this class because the new approach will be also added here so we can assign ru variant before initialisation.
I thought it was a good place to also add the preferences removal for the moment.

@nalcalag nalcalag marked this pull request as ready for review January 10, 2024 15:03
Copy link
Contributor

@marcosholgado marcosholgado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nalcalag nalcalag merged commit 290ec47 into develop Jan 11, 2024
8 checks passed
@nalcalag nalcalag deleted the feature/noelia/remove_backup_service branch January 11, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants