Remove backup service

app/build.gradle

@@ -315,9 +315,6 @@ dependencies {
     implementation project(':broken-site-impl')
     implementation project(':broken-site-store')
 
-    implementation project(':backup-agent-api')
-    implementation project(':backup-agent-impl')
-
     // Deprecated. TODO: Stop using this artifact.
     implementation "androidx.legacy:legacy-support-v4:_"
     debugImplementation Square.leakCanary.android

app/src/main/AndroidManifest.xml

@@ -32,8 +32,7 @@
 
     <application
         android:name="com.duckduckgo.app.global.DuckDuckGoApplication"
-        android:backupAgent="com.duckduckgo.app.backup.agent.impl.DuckDuckGoBackupAgent"
-        android:fullBackupOnly="false"
+        android:allowBackup="false"
         android:icon="${appIcon}"
         android:label="@string/appName"
         android:networkSecurityConfig="@xml/network_security_config"
@@ -42,8 +41,6 @@
         android:theme="@style/Theme.DuckDuckGo.Light"
         android:requestLegacyExternalStorage="true"
         tools:ignore="GoogleAppIndexingWarning">
-        <meta-data android:name="com.google.android.backup.api_key"
-                   android:value="unused" />
         <meta-data
             android:name="android.webkit.WebView.MetricsOptOut"
             android:value="true" />

app/src/main/java/com/duckduckgo/app/reinstalls/BackupServiceDataStore.kt

@@ -0,0 +1,52 @@
+/*
+ * Copyright (c) 2024 DuckDuckGo
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.duckduckgo.app.reinstalls
+
+import android.content.Context
+import android.content.SharedPreferences
+import com.duckduckgo.di.scopes.AppScope
+import com.squareup.anvil.annotations.ContributesBinding
+import javax.inject.Inject
+
+interface BackupServiceDataStore {
+    fun clearBackupPreferences()
+}
+
+@ContributesBinding(AppScope::class)
+class BackupServiceSharedPreferences @Inject constructor(
+    private val context: Context,
+) : BackupServiceDataStore {
+
+    private val backupServicePreferences: SharedPreferences by lazy { context.getSharedPreferences(FILENAME_BACKUP_SERVICE, Context.MODE_PRIVATE) }
+    private val backupPixelPreferences: SharedPreferences by lazy { context.getSharedPreferences(FILENAME_BACKUP_PIXEL, Context.MODE_PRIVATE) }
+
+    override fun clearBackupPreferences() {
+        if (backupServicePreferences.contains(KEY_ATB)) {
+            backupServicePreferences.edit().clear().apply()
+        }
+        if (backupPixelPreferences.contains(KEY_PIXEL_SENT)) {
+            backupPixelPreferences.edit().clear().apply()
+        }
+    }
+
+    companion object {
+        private const val FILENAME_BACKUP_SERVICE = "com.duckduckgo.app.statistics.backup"
+        private const val KEY_ATB = "com.duckduckgo.app.statistics.backup.atb"
+        private const val FILENAME_BACKUP_PIXEL = "com.duckduckgo.app.statistics.backup.pixel"
+        private const val KEY_PIXEL_SENT = "com.duckduckgo.app.statistics.backup.pixel.sent"
+    }
+}

backup-agent/backup-agent-impl/src/main/java/com/duckduckgo/app/backup/agent/impl/ReinstallAtbListener.kt → app/src/main/java/com/duckduckgo/app/reinstalls/ReinstallAtbListener.kt

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2023 DuckDuckGo
+ * Copyright (c) 2024 DuckDuckGo
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -14,33 +14,21 @@
  * limitations under the License.
  */
 
-package com.duckduckgo.app.backup.agent.impl
+package com.duckduckgo.app.reinstalls
 
-import com.duckduckgo.app.backup.agent.impl.BackupAgentManagerImpl.Companion.REINSTALL_VARIANT
-import com.duckduckgo.app.backup.agent.impl.store.BackupDataStore
 import com.duckduckgo.app.statistics.AtbInitializerListener
-import com.duckduckgo.app.statistics.store.StatisticsDataStore
 import com.duckduckgo.di.scopes.AppScope
 import com.squareup.anvil.annotations.ContributesMultibinding
 import dagger.SingleInstanceIn
 import javax.inject.Inject
-import timber.log.Timber
 
 @SingleInstanceIn(AppScope::class)
 @ContributesMultibinding(AppScope::class)
 class ReinstallAtbListener @Inject constructor(
-    private val statisticsDataStore: StatisticsDataStore,
-    private val backupDataStore: BackupDataStore,
+    private val backupDataStore: BackupServiceDataStore,
 ) : AtbInitializerListener {
     override suspend fun beforeAtbInit() {
-        if (statisticsDataStore.hasInstallationStatistics && backupDataStore.atb != statisticsDataStore.atb) {
-            backupDataStore.atb = statisticsDataStore.atb
-        }
-        if (!statisticsDataStore.hasInstallationStatistics && backupDataStore.atb != null) {
-            backupDataStore.atb = null
-            statisticsDataStore.variant = REINSTALL_VARIANT
-            Timber.d("Variant update for returning user")
-        }
+        backupDataStore.clearBackupPreferences()
     }
 
     override fun beforeAtbInitTimeoutMillis(): Long = MAX_REINSTALL_WAIT_TIME_MS

app/src/test/java/com/duckduckgo/app/reinstalls/ReinstallAtbListenerTest.kt

@@ -0,0 +1,47 @@
+/*
+ * Copyright (c) 2024 DuckDuckGo
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.duckduckgo.app.reinstalls
+
+import com.duckduckgo.common.test.CoroutineTestRule
+import kotlinx.coroutines.test.runTest
+import org.junit.Before
+import org.junit.Rule
+import org.junit.Test
+import org.mockito.kotlin.mock
+import org.mockito.kotlin.verify
+
+class ReinstallAtbListenerTest {
+
+    private lateinit var testee: ReinstallAtbListener
+
+    private val mockBackupDataStore: BackupServiceDataStore = mock()
+
+    @get:Rule
+    val coroutineTestRule: CoroutineTestRule = CoroutineTestRule()
+
+    @Before
+    fun before() {
+        testee = ReinstallAtbListener(mockBackupDataStore)
+    }
+
+    @Test
+    fun whenBeforeAtbInitIsCalledThenClearBackupServiceSharedPreferences() = runTest {
+        testee.beforeAtbInit()
+
+        verify(mockBackupDataStore).clearBackupPreferences()
+    }
+}