Integrate privacy dashboard #5593
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 4, 2025
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Base automatically changed from
feature/cris/malicious-site-protection/add-feed-to-return-type
to
develop
February 4, 2025 16:26
CrisBarreiro
force-pushed
the
feature/cris/malicious-site-protection/integrate-privacy-dashboard
branch
from
25e8875 to
44269fd
Compare
5 tasks
CrisBarreiro
force-pushed
the
feature/cris/malicious-site-protection/integrate-privacy-dashboard
branch
from
44269fd to
e52cd0f
Compare
cmonfortep
approved these changes
Feb 5, 2025
| @@ -289,6 +290,7 @@ class PrivacyDashboardHybridViewModel @Inject constructor( | |||
| protectionStatus = protectionStatusViewStateMapper.mapFromSite(site), | |||
| cookiePromptManagementStatus = autoconsentStatusViewStateMapper.mapFromSite(site), | |||
| remoteFeatureSettings = createRemoteFeatureSettings(), | |||
| maliciousSiteStatus = site.maliciousSiteStatus?.name?.lowercase(), | |||
There was a problem hiding this comment.
Fine, but I expect they ignoreCase in the JS side... :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1205008441501016/1208836754662808
Description
Steps to test this PR
Pre-requisites
npm i github:duckduckgo/privacy-dashboard#pr-releases/pr-300Feature 1
UI changes