Add omnibar icon for exempted malicious site #5594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
malmstein
approved these changes
Feb 4, 2025
There was a problem hiding this comment.
Works as expected, thanks @CrisBarreiro !
I’ve added a question about the colors, but nothing that blocks this PR.
| WARNING -> { | ||
| val res = if (appTheme.isLightModeEnabled()) R.raw.unprotected_shield else R.raw.dark_unprotected_shield | ||
| MALICIOUS -> { | ||
| val res = R.raw.alert_red |
There was a problem hiding this comment.
Asked in https://app.asana.com/0/1203867924525323/1209269732493260 about the single file for both themes.
There was a problem hiding this comment.
Good catch, I initially thought we probably didn't need to do anything, but I had forgotten about the different shade of red. Thanks!
CrisBarreiro
force-pushed
the
feature/cris/malicious-site-protection/integrate-privacy-dashboard
branch
from
44269fd to
e52cd0f
Compare
CrisBarreiro
force-pushed
the
feature/cris/malicious-site-protection/add-exempted-site-omnibar-icon
branch
from
2dc9c0c to
b85824f
Compare
CrisBarreiro
merged commit b85824f
into
feature/cris/malicious-site-protection/integrate-privacy-dashboard
2 of 5 checks passed
CrisBarreiro
deleted the
feature/cris/malicious-site-protection/add-exempted-site-omnibar-icon
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1205008441501016/1209289567264350
Description
Add omnibar icon for exempted malicious site
Steps to test this PR
Feature 1
UI changes