Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(hard-fork): Implement rollapp hard fork #1354

Merged
merged 76 commits into from
Nov 14, 2024
Merged

feat(hard-fork): Implement rollapp hard fork #1354

merged 76 commits into from
Nov 14, 2024

Conversation

mtsitrin
Copy link
Contributor

@mtsitrin mtsitrin commented Oct 28, 2024 •
edited
Loading

x/rollapp:

  • removed frozen notation from rollapp object
  • added revisionNumber to rollapp object
  • implemented the state revert for x/rollapp
  • basic sequencer handling

sepatate PRs:

updated after x/sequencer changes: #1406
support recovery from halt: #1455

follow ups:
#1466
#1465

omritoptix
omritoptix reviewed Oct 30, 2024
View reviewed changes
Copy link
Contributor

@omritoptix omritoptix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job

x/rollapp/keeper/fraud_handler.go Outdated Show resolved Hide resolved
x/rollapp/keeper/fraud_handler.go Outdated Show resolved Hide resolved
x/rollapp/keeper/fraud_handler.go Outdated Show resolved Hide resolved
x/rollapp/keeper/fraud_handler.go Outdated Show resolved Hide resolved
x/rollapp/keeper/fraud_handler.go Outdated Show resolved Hide resolved
x/rollapp/keeper/fraud_handler.go Outdated Show resolved Hide resolved
x/rollapp/keeper/fraud_handler.go Outdated Show resolved Hide resolved
@mtsitrin mtsitrin changed the base branch from feat/hard_fork_adr to main October 31, 2024 10:03
@mtsitrin mtsitrin linked an issue Oct 31, 2024 that may be closed by this pull request
Rollapp Hard fork (hub side) - Impl #937
Closed
@mtsitrin mtsitrin changed the title feat(hard_fork): part 1 (x/rollapp) feat(hard_fork): Implementing Hard Fork Oct 31, 2024
@omritoptix omritoptix changed the title feat(hard-fork): Implementing Hard Fork feat(hard-fork): Implement rollapp hard fork Nov 10, 2024
@mtsitrin mtsitrin linked an issue Nov 11, 2024 that may be closed by this pull request
Tech debt: bring back old light client tests #1364
Closed
@mtsitrin mtsitrin linked an issue Nov 11, 2024 that may be closed by this pull request
tech debt: refactor light client prune above and below #1397
Closed
danwt
danwt reviewed Nov 11, 2024
View reviewed changes
Copy link
Contributor

@danwt danwt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple questions

  • need to hard for on wrong DRS?
  • what is intended behaviour with double sign, need a different gov prop?
  • import/export genesis

x/rollapp/keeper/msg_server_update_state.go Show resolved Hide resolved
x/rollapp/keeper/msg_server_update_state.go Outdated Show resolved Hide resolved
x/rollapp/keeper/hard_fork.go Outdated Show resolved Hide resolved
x/rollapp/keeper/fraud_proposal.go Outdated Show resolved Hide resolved
x/rollapp/keeper/fraud_proposal.go Outdated Show resolved Hide resolved
x/lightclient/keeper/hook_listener.go Outdated Show resolved Hide resolved
x/delayedack/keeper/fraud.go Outdated Show resolved Hide resolved
x/lightclient/keeper/rollback.go Outdated Show resolved Hide resolved
x/rollapp/keeper/msg_server_create_rollapp.go Outdated Show resolved Hide resolved
x/rollapp/keeper/fraud_proposal.go Outdated Show resolved Hide resolved
@danwt danwt mentioned this pull request Nov 11, 2024
Merged
omritoptix
omritoptix requested changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@omritoptix omritoptix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getting there!

I think there is one bug though (look at comments)

x/rollapp/keeper/hard_fork.go Show resolved Hide resolved
x/sequencer/keeper/proposer.go Outdated Show resolved Hide resolved
x/lightclient/keeper/keeper.go Outdated Show resolved Hide resolved
omritoptix
omritoptix previously approved these changes Nov 14, 2024
View reviewed changes
danwt
danwt approved these changes Nov 14, 2024
View reviewed changes
x/rollapp/keeper/fraud_proposal.go Show resolved Hide resolved
x/sequencer/keeper/msg_server_bond.go Show resolved Hide resolved
x/sequencer/keeper/msg_server_bond.go Show resolved Hide resolved
@danwt danwt merged commit 5deae85 into main Nov 14, 2024
5 checks passed
@danwt danwt deleted the mtsitrin/937-rollapp-hard-fork-hub-side branch November 14, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danwt danwt danwt approved these changes

@omritoptix omritoptix omritoptix approved these changes

Assignees
No one assigned
Labels
dym-internal
Projects
None yet
Milestone
No milestone
5 participants
@mtsitrin @omritoptix @danwt @keruch @zale144