Correctly parse the API URL in dashboard #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mishushakov
approved these changes
Dec 18, 2024
Agree. This is a quick fix. New dashboard should handle this better |
0div
approved these changes
Dec 18, 2024
| @@ -45,7 +53,7 @@ export const DeveloperContent = ({ | |||
| <pre className="mt-2 w-full bg-neutral-700 px-2 py-1 rounded-md text-brand-300"> | |||
| E2B_DOMAIN={ | |||
| isUrl(apiUrl) | |||
| ? `"${new URL(apiUrl).host}"` | |||
| ? `"${removeApiSubdomain(new URL(apiUrl))}"` | |||
There was a problem hiding this comment.
Suggested change
| ? `"${removeApiSubdomain(new URL(apiUrl))}"` | |
| ? removeApiSubdomain(new URL(apiUrl)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a bug when a user passes a custom API URL like
https://api.e2b-cluster.devand we incorrectly print that the user should set theirE2B_DOMAINtoapi.e2b-cluster.devwhile the correct one would beE2B_DOMAIN=e2b-cluster.dev.