Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly parse the API URL in dashboard #511

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Correctly parse the API URL in dashboard #511

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion apps/web/src/components/Dashboard/Developer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,14 @@ export const DeveloperContent = ({
}
}

function removeApiSubdomain(url: URL): string {
const hostParts = url.host.split('.')
if (hostParts.length > 2 && hostParts[0] === 'api') {
return hostParts.slice(1).join('.')
}
return url.host
}

return (
<div className="flex flex-col w-full">
<div className="flex flex-col h-full">
Expand All @@ -45,7 +53,7 @@ export const DeveloperContent = ({
<pre className="mt-2 w-full bg-neutral-700 px-2 py-1 rounded-md text-brand-300">
E2B_DOMAIN={
isUrl(apiUrl)
? `"${new URL(apiUrl).host}"`
? `"${removeApiSubdomain(new URL(apiUrl))}"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
? `"${removeApiSubdomain(new URL(apiUrl))}"`
? removeApiSubdomain(new URL(apiUrl))

: 'Invalid URL'
}
</pre>
Expand Down
Loading