Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21908] Adjust XML snippets to meet QoS constraints #934

Merged
merged 3 commits into from
Oct 17, 2024
Merged

[21908] Adjust XML snippets to meet QoS constraints #934

merged 3 commits into from
Oct 17, 2024

Conversation

JesusPoderoso
Copy link
Contributor

@JesusPoderoso JesusPoderoso commented Oct 16, 2024 •
edited by MiguelCompany
Loading

Description

This PR updates the XML snippets to meet the resource limits QoS constraints

@Mergifyio backport 3.0.x 2.14.x 2.10.x 2.6.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A Code snippets related to the added documentation have been provided.
  • Documentation tests pass locally.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

@JesusPoderoso JesusPoderoso added this to the v3.1.1 milestone Oct 16, 2024
@JesusPoderoso JesusPoderoso self-assigned this Oct 16, 2024
@JesusPoderoso JesusPoderoso removed the request for review from richiprosima October 16, 2024 21:13
@JesusPoderoso JesusPoderoso marked this pull request as ready for review October 16, 2024 21:13
MiguelCompany
MiguelCompany requested changes Oct 17, 2024
View reviewed changes
code/XMLTester.xml Outdated Show resolved Hide resolved
code/XMLTester.xml Outdated Show resolved Hide resolved
code/XMLTester.xml Show resolved Hide resolved
@JesusPoderoso
Copy link
Contributor Author

@Mergifyio backport 3.0.x 2.14.x 2.10.x 2.6.x

@JesusPoderoso JesusPoderoso merged commit d60571d into master Oct 17, 2024
4 checks passed
@JesusPoderoso JesusPoderoso deleted the hotfix/21908 branch October 17, 2024 10:53
@mergify Mergify
Copy link

mergify bot commented Oct 17, 2024 •
edited
Loading

backport 3.0.x 2.14.x 2.10.x 2.6.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 17, 2024
@JesusPoderoso @mergify
Adjust XML snippets to meet QoS constraints (#934)
bef4245 
* Refs #21908: Adjust XML snippets to meet QoS constraints

Signed-off-by: eProsima <[email protected]>

* Refs #21908: ARS - Revert unnecessary changes

Signed-off-by: eProsima <[email protected]>

* Refs #21908: ARS - Add missing snippet change

Signed-off-by: eProsima <[email protected]>

---------

Signed-off-by: eProsima <[email protected]>
(cherry picked from commit d60571d)
@mergify mergify bot mentioned this pull request Oct 17, 2024
Merged
7 tasks
mergify bot pushed a commit that referenced this pull request Oct 17, 2024
@JesusPoderoso @mergify
Adjust XML snippets to meet QoS constraints (#934)
95900dc 
* Refs #21908: Adjust XML snippets to meet QoS constraints

Signed-off-by: eProsima <[email protected]>

* Refs #21908: ARS - Revert unnecessary changes

Signed-off-by: eProsima <[email protected]>

* Refs #21908: ARS - Add missing snippet change

Signed-off-by: eProsima <[email protected]>

---------

Signed-off-by: eProsima <[email protected]>
(cherry picked from commit d60571d)

# Conflicts:
#	code/DDSCodeTester.cpp
@mergify mergify bot mentioned this pull request Oct 17, 2024
Open
7 tasks
mergify bot pushed a commit that referenced this pull request Oct 17, 2024
@JesusPoderoso @mergify
Adjust XML snippets to meet QoS constraints (#934)
e4b93d1 
* Refs #21908: Adjust XML snippets to meet QoS constraints

Signed-off-by: eProsima <[email protected]>

* Refs #21908: ARS - Revert unnecessary changes

Signed-off-by: eProsima <[email protected]>

* Refs #21908: ARS - Add missing snippet change

Signed-off-by: eProsima <[email protected]>

---------

Signed-off-by: eProsima <[email protected]>
(cherry picked from commit d60571d)

# Conflicts:
#	code/DDSCodeTester.cpp
@mergify mergify bot mentioned this pull request Oct 17, 2024
Open
7 tasks
mergify bot pushed a commit that referenced this pull request Oct 17, 2024
@JesusPoderoso @mergify
Adjust XML snippets to meet QoS constraints (#934)
1013d82 
* Refs #21908: Adjust XML snippets to meet QoS constraints

Signed-off-by: eProsima <[email protected]>

* Refs #21908: ARS - Revert unnecessary changes

Signed-off-by: eProsima <[email protected]>

* Refs #21908: ARS - Add missing snippet change

Signed-off-by: eProsima <[email protected]>

---------

Signed-off-by: eProsima <[email protected]>
(cherry picked from commit d60571d)

# Conflicts:
#	code/DDSCodeTester.cpp
@mergify mergify bot mentioned this pull request Oct 17, 2024
Open
7 tasks
JesusPoderoso added a commit that referenced this pull request Oct 17, 2024
@mergify @JesusPoderoso
Adjust XML snippets to meet QoS constraints (#934) (#941)
ad4cf9d 
* Refs #21908: Adjust XML snippets to meet QoS constraints

Signed-off-by: eProsima <[email protected]>

* Refs #21908: ARS - Revert unnecessary changes

Signed-off-by: eProsima <[email protected]>

* Refs #21908: ARS - Add missing snippet change

Signed-off-by: eProsima <[email protected]>

---------

Signed-off-by: eProsima <[email protected]>
(cherry picked from commit d60571d)

Co-authored-by: Jesús Poderoso <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees

@JesusPoderoso JesusPoderoso

Labels
ready-to-merge
Projects
None yet
Milestone
v3.1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@JesusPoderoso @MiguelCompany