[21793] Easy Mode Implementation #5548

cferreiragonz · 2025-01-08T10:20:03Z

Description

This PR updates the CLI to make it compatible with the new Fast DDS Auto Discovery Server Mode using a XML-RPC server to host a daemon.

Must be merged after:

Contributor Checklist

Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally. DS Tests: [21793] Easy Mode Implementation - Tests Discovery-Server#112
Any new/modified methods have been properly documented using Doxygen.
Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
N/A Changes are backport compatible: they do NOT break ABI nor change library core behavior.
N/A Changes are API compatible.
New feature has been added to the versions.md file (if applicable).
New feature has been documented/Current behavior is correctly described in the documentation.
Related documentation PR: [22427] Fast DDS EASY_MODE - Feature - XMLRPC Server Fast-DDS-docs#1020
N/A Applicable backports have been included in the description.

Reviewer Checklist

The PR has a milestone assigned.
The title and description correctly express the PR's purpose.
Check contributor checklist is correct.
If this is a critical bug fix, backports to the critical-only supported branches have been requested.
Check CI results: changes do not issue any warning.
Check CI results: failing tests are unrelated with the changes.

Mario-DL

Nice job daemonizing, leaving the review.
I am about to test the complete feature under a ROS 2 environment

include/fastdds/rtps/common/PortParameters.hpp

tools/fastdds/discovery/parser.py

test/system/tools/fds/CMakeLists.txt

tools/fastdds/discovery/fast_daemon/daemon/__init__.py

tools/fds/CliDiscoveryManager.hpp

test/system/tools/fastdds/test_discovery_parser.py

test/system/tools/fds/CliDiscoveryManagerTests.cpp

tools/fds/CliDiscoveryEntrypoint.cpp

Mario-DL · 2025-01-09T13:36:55Z

One NIT, I think we should rename the fast_daemon folder name to fastdds_daemon, xmlrpc_daemon, daemon or smth similar

tools/fastdds/discovery/fast_daemon/process_handler/process_handler.py

tools/fastdds/discovery/parser.py

test/system/tools/fds/CMakeLists.txt

Mario-DL

LGTM with green CI on #5551

Signed-off-by: cferreiragonz <[email protected]>

* Refs #22352: Add preferred_domain_id to PubSubAPI Signed-off-by: Mario Dominguez <[email protected]> * Refs #22352: Refactor set_on_discovery_function in PubSubAPI Signed-off-by: Mario Dominguez <[email protected]> * Refs #22352: Add get_participants_matched() in PubSubAPI Signed-off-by: Mario Dominguez <[email protected]> * Refs #22352: Update BB tests with new APIs Signed-off-by: Mario Dominguez <[email protected]> * Refs #22352: Add Auto Discovery Mode BB tests Signed-off-by: Mario Dominguez <[email protected]> * Refs #22427: New DS_AUTO BuiltinTransport option Signed-off-by: Mario Dominguez <[email protected]> * Refs #22427: SystemCommandBuilder class Signed-off-by: Mario Dominguez <[email protected]> * Refs #22427: Feature Impl Signed-off-by: Mario Dominguez <[email protected]> * Refs #22427: Fix tests compilation in all platforms Signed-off-by: Mario Dominguez <[email protected]> * Refs #22427: Apply Carlo's review Signed-off-by: Mario Dominguez <[email protected]> * Refs #22427: stop background servers with stop instead of shutdown in BB tests Signed-off-by: Mario Dominguez <[email protected]> * Refs #22427: Update banner Signed-off-by: cferreiragonz <[email protected]> * Refs #22627: Rename DS_AUTO transport to P2P Signed-off-by: Mario Dominguez <[email protected]> * Refs #22627: Refactor BB tests with EASY_MODE Signed-off-by: Mario Dominguez <[email protected]> * Refs #22627: Refactor feature impl with EASY_MODE Signed-off-by: Mario Dominguez <[email protected]> * Refs #22627: Distinguish Log error if the EASY_MODE IP conflicts with a previous one Signed-off-by: Mario Dominguez <[email protected]> * Refs #22627: Review NIT Signed-off-by: Mario Dominguez <[email protected]> * Refs #22627: Feature use UDP for metatraffic Signed-off-by: Mario Dominguez <[email protected]> * Refs #22627: UDP metatraffic Cli Signed-off-by: Mario Dominguez <[email protected]> * Refs #22627: Feature with UDP BB tests Signed-off-by: Mario Dominguez <[email protected]> * Refs #22627: Remove unsued line Signed-off-by: Mario Dominguez <[email protected]> * Refs #22627: Feature with UDP CLI tests Signed-off-by: cferreiragonz <[email protected]> * Refs #22627: Avoid macro collision in MacOS Signed-off-by: Mario Domínguez López <[email protected]> --------- Signed-off-by: Mario Dominguez <[email protected]> Signed-off-by: cferreiragonz <[email protected]> Signed-off-by: Mario Domínguez López <[email protected]> Co-authored-by: Mario Dominguez <[email protected]>

Signed-off-by: cferreiragonz <[email protected]>

Mario-DL

LGTM with green CI

Signed-off-by: cferreiragonz <[email protected]>

src/cpp/rtps/attributes/ServerAttributes.hpp

src/cpp/rtps/attributes/ServerAttributes.cpp

src/cpp/rtps/attributes/ServerAttributes.hpp

src/cpp/rtps/attributes/ServerAttributes.cpp

src/cpp/rtps/RTPSDomain.cpp

cferreiragonz force-pushed the feature/auto_ds_daemonized branch 2 times, most recently from 5d6e50e to eaf2387 Compare January 8, 2025 13:23

cferreiragonz requested review from richiprosima and removed request for richiprosima January 8, 2025 13:47

github-actions bot added the ci-pending PR which CI is running label Jan 8, 2025

cferreiragonz force-pushed the feature/auto_ds_daemonized branch from eaf2387 to 4871cf4 Compare January 8, 2025 13:56

cferreiragonz requested review from richiprosima and removed request for richiprosima January 8, 2025 13:58

cferreiragonz force-pushed the feature/auto_ds_daemonized branch from 4871cf4 to 910729f Compare January 9, 2025 11:14

Mario-DL requested changes Jan 9, 2025

View reviewed changes

cferreiragonz force-pushed the feature/auto_ds_daemonized branch from 910729f to e7c0a85 Compare January 9, 2025 13:40

Mario-DL reviewed Jan 10, 2025

View reviewed changes

tools/fastdds/discovery/fast_daemon/process_handler/process_handler.py Outdated Show resolved Hide resolved

Mario-DL reviewed Jan 10, 2025

View reviewed changes

tools/fastdds/discovery/fast_daemon/process_handler/process_handler.py Outdated Show resolved Hide resolved

Mario-DL reviewed Jan 10, 2025

View reviewed changes

tools/fastdds/discovery/parser.py Outdated Show resolved Hide resolved

cferreiragonz force-pushed the feature/auto_ds_daemonized branch from e7c0a85 to 6465cd4 Compare January 10, 2025 09:38

Mario-DL reviewed Jan 10, 2025

View reviewed changes

test/system/tools/fds/CMakeLists.txt Outdated Show resolved Hide resolved

Mario-DL previously approved these changes Jan 10, 2025

View reviewed changes

cferreiragonz requested review from richiprosima and removed request for richiprosima January 10, 2025 11:01

cferreiragonz dismissed Mario-DL’s stale review via 308bc53 January 15, 2025 13:50

cferreiragonz force-pushed the feature/auto_ds_daemonized branch 9 times, most recently from 091c26f to 143ce0d Compare January 16, 2025 16:29

cferreiragonz and others added 13 commits January 22, 2025 10:36

Refs #22518: Add Fast DDS XML-RPC Daemon

6bce330

Signed-off-by: cferreiragonz <[email protected]>

Refs #22518: Test enum

68823ef

Signed-off-by: cferreiragonz <[email protected]>

Refs #22518: Cancel fork in cpp tool

a4b62cf

Signed-off-by: cferreiragonz <[email protected]>

Refs #22518: Add parser tests

d2a83a5

Signed-off-by: cferreiragonz <[email protected]>

Refs #22518: Apply Revision

c2e40a4

Signed-off-by: cferreiragonz <[email protected]>

Refs #22518: Review - Use stop to shutdown server

e3feef8

Signed-off-by: cferreiragonz <[email protected]>

Refs #22518: Apply Revision 2

eba9be9

Signed-off-by: cferreiragonz <[email protected]>

Refs #22623: Allow TCP reconnections

70285bf

Signed-off-by: cferreiragonz <[email protected]>

Refs #22518: Fix build in Ubuntu24

06a5941

Signed-off-by: cferreiragonz <[email protected]>

Refs #22627: Add EASY_MODE to parser

321e284

Signed-off-by: cferreiragonz <[email protected]>

Refs #22518: Improve unittest robustness

06e6282

Signed-off-by: cferreiragonz <[email protected]>

Refs #22627: logs, comments, versions, displays

e64989e

Signed-off-by: cferreiragonz <[email protected]>

cferreiragonz force-pushed the feature/auto_ds_daemonized branch from 2ef8051 to 757a1f9 Compare January 22, 2025 10:12

Mario-DL previously approved these changes Jan 22, 2025

View reviewed changes

Mario-DL requested review from Mario-DL and removed request for Mario-DL January 22, 2025 10:15

cferreiragonz added 2 commits January 22, 2025 15:39

Refs #22627: Review - Logs

034e7d5

Signed-off-by: cferreiragonz <[email protected]>

Refs #22627: ROS2_EASY_MODE

04b363a

Signed-off-by: cferreiragonz <[email protected]>

cferreiragonz dismissed Mario-DL’s stale review via 04b363a January 22, 2025 14:39

cferreiragonz force-pushed the feature/auto_ds_daemonized branch from 757a1f9 to 04b363a Compare January 22, 2025 14:39

cferreiragonz mentioned this pull request Jan 22, 2025

[22427] Fast DDS EASY_MODE - Feature - XMLRPC Server eProsima/Fast-DDS-docs#1020

Merged

7 tasks

cferreiragonz requested a review from Mario-DL January 22, 2025 14:53

Mario-DL requested changes Jan 23, 2025

View reviewed changes

Mario-DL approved these changes Jan 23, 2025

View reviewed changes

cferreiragonz added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Jan 23, 2025

Mario-DL merged commit 2923161 into master Jan 23, 2025
17 checks passed

Mario-DL deleted the feature/auto_ds_daemonized branch January 23, 2025 07:39

Mario-DL mentioned this pull request Jan 23, 2025

[22627] Rename EASY_MODE_URI and easy_mode_env() #5593

Open

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[21793] Easy Mode Implementation #5548

[21793] Easy Mode Implementation #5548

cferreiragonz commented Jan 8, 2025 •

edited by Mario-DL

Loading

Mario-DL left a comment

Mario-DL commented Jan 9, 2025

Mario-DL left a comment

Mario-DL left a comment

[21793] Easy Mode Implementation #5548

[21793] Easy Mode Implementation #5548

Conversation

cferreiragonz commented Jan 8, 2025 • edited by Mario-DL Loading

Description

Contributor Checklist

Reviewer Checklist

Mario-DL left a comment

Choose a reason for hiding this comment

Mario-DL commented Jan 9, 2025

Mario-DL left a comment

Choose a reason for hiding this comment

Mario-DL left a comment

Choose a reason for hiding this comment

cferreiragonz commented Jan 8, 2025 •

edited by Mario-DL

Loading