Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[22658] Reliable volatile change dropped when all history acked #5606

Merged
merged 4 commits into from
Jan 30, 2025
Merged

[22658] Reliable volatile change dropped when all history acked #5606

merged 4 commits into from
Jan 30, 2025

Conversation

juanjo4936
Copy link
Contributor

@juanjo4936 juanjo4936 commented Jan 28, 2025 •
edited by EugenioCollado
Loading

When the entire history is acked in volatile, given that the entries are deleted from the history, check_acked_status satisfies min_low_mark >= get_seq_num_min() because seq_num_min is unknown. This makes try_remove to fail, because it tries to remove changes but there were none. This causes prepare_change to not perform the changes, since the history was full and could not delete any changes.

@Mergifyio backport 3.1.x 3.0.x 2.14.x 2.10.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@juanjo4936
Refs #22658: Regression test
034f674 
Signed-off-by: Juanjo Garcia <[email protected]>
@juanjo4936 juanjo4936 added this to the v3.2.0 milestone Jan 28, 2025
@github-actions github-actions bot added the ci-pending PR which CI is running label Jan 28, 2025
@juanjo4936
Refs #22658: Fix bug
c1e2ee7 
Signed-off-by: Juanjo Garcia <[email protected]>
@juanjo4936
Refs #22658: corrected failing CI
92c93c3 
Signed-off-by: Juanjo Garcia <[email protected]>
@juanjo4936 juanjo4936 requested review from richiprosima and removed request for richiprosima January 29, 2025 07:41
@EugenioCollado EugenioCollado added skip-ci Automatically pass CI and removed ci-pending PR which CI is running labels Jan 29, 2025
@EugenioCollado EugenioCollado self-requested a review January 29, 2025 13:22
@juanjo4936 juanjo4936 added ci-pending PR which CI is running and removed skip-ci Automatically pass CI labels Jan 29, 2025
@juanjo4936 juanjo4936 requested review from richiprosima and removed request for richiprosima January 29, 2025 15:15
@juanjo4936 juanjo4936 force-pushed the fix/reliable_history_acked branch from 5a968ab to 7cdbaf3 Compare January 29, 2025 15:17
@juanjo4936 juanjo4936 requested review from richiprosima and removed request for richiprosima January 29, 2025 15:18
@juanjo4936 juanjo4936 force-pushed the fix/reliable_history_acked branch from 7cdbaf3 to 2087ccd Compare January 29, 2025 15:22
@juanjo4936 juanjo4936 requested review from richiprosima and removed request for richiprosima January 29, 2025 15:23
EugenioCollado
EugenioCollado approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@EugenioCollado EugenioCollado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juanjo4936 juanjo4936 merged commit 90790ce into master Jan 30, 2025
17 checks passed
@juanjo4936 juanjo4936 deleted the fix/reliable_history_acked branch January 30, 2025 11:24
@juanjo4936
Copy link
Contributor Author

https://github.com/Mergifyio backport 3.1.x 3.0.x 2.14.x 2.10.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 30, 2025 •
edited
Loading

backport 3.1.x 3.0.x 2.14.x 2.10.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 30, 2025
@juanjo4936 @mergify
Reliable volatile change dropped when all history acked (#5606)
83ea4ce 
* Refs #22658: Regression test

Signed-off-by: Juanjo Garcia <[email protected]>

* Refs #22658: Fix bug

Signed-off-by: Juanjo Garcia <[email protected]>

* Refs #22658: corrected failing CI

Signed-off-by: Juanjo Garcia <[email protected]>

* Refs #22658: Included reviewer suggestions

Signed-off-by: Juanjo Garcia <[email protected]>

---------

Signed-off-by: Juanjo Garcia <[email protected]>
(cherry picked from commit 90790ce)
mergify bot pushed a commit that referenced this pull request Jan 30, 2025
@juanjo4936 @mergify
Reliable volatile change dropped when all history acked (#5606)
ddf4bb9 
* Refs #22658: Regression test

Signed-off-by: Juanjo Garcia <[email protected]>

* Refs #22658: Fix bug

Signed-off-by: Juanjo Garcia <[email protected]>

* Refs #22658: corrected failing CI

Signed-off-by: Juanjo Garcia <[email protected]>

* Refs #22658: Included reviewer suggestions

Signed-off-by: Juanjo Garcia <[email protected]>

---------

Signed-off-by: Juanjo Garcia <[email protected]>
(cherry picked from commit 90790ce)
This was referenced Jan 30, 2025
Merged
Merged
mergify bot pushed a commit that referenced this pull request Jan 30, 2025
@juanjo4936 @mergify
Reliable volatile change dropped when all history acked (#5606)
e2df968 
* Refs #22658: Regression test

Signed-off-by: Juanjo Garcia <[email protected]>

* Refs #22658: Fix bug

Signed-off-by: Juanjo Garcia <[email protected]>

* Refs #22658: corrected failing CI

Signed-off-by: Juanjo Garcia <[email protected]>

* Refs #22658: Included reviewer suggestions

Signed-off-by: Juanjo Garcia <[email protected]>

---------

Signed-off-by: Juanjo Garcia <[email protected]>
(cherry picked from commit 90790ce)
@mergify mergify bot mentioned this pull request Jan 30, 2025
Merged
12 tasks
mergify bot pushed a commit that referenced this pull request Jan 30, 2025
@juanjo4936 @mergify
Reliable volatile change dropped when all history acked (#5606)
8871834 
* Refs #22658: Regression test

Signed-off-by: Juanjo Garcia <[email protected]>

* Refs #22658: Fix bug

Signed-off-by: Juanjo Garcia <[email protected]>

* Refs #22658: corrected failing CI

Signed-off-by: Juanjo Garcia <[email protected]>

* Refs #22658: Included reviewer suggestions

Signed-off-by: Juanjo Garcia <[email protected]>

---------

Signed-off-by: Juanjo Garcia <[email protected]>
(cherry picked from commit 90790ce)
@mergify mergify bot mentioned this pull request Jan 30, 2025
Open
12 tasks
@EugenioCollado EugenioCollado restored the fix/reliable_history_acked branch January 31, 2025 07:47
@EugenioCollado EugenioCollado deleted the fix/reliable_history_acked branch January 31, 2025 07:49
EugenioCollado pushed a commit that referenced this pull request Feb 3, 2025
@juanjo4936 @EugenioCollado
Reliable volatile change dropped when all history acked (#5606)
8977954 
* Refs #22658: Regression test

Signed-off-by: Juanjo Garcia <[email protected]>

* Refs #22658: Fix bug

Signed-off-by: Juanjo Garcia <[email protected]>

* Refs #22658: corrected failing CI

Signed-off-by: Juanjo Garcia <[email protected]>

* Refs #22658: Included reviewer suggestions

Signed-off-by: Juanjo Garcia <[email protected]>

---------

Signed-off-by: Juanjo Garcia <[email protected]>
(cherry picked from commit 90790ce)
MiguelCompany pushed a commit that referenced this pull request Feb 4, 2025
@mergify @juanjo4936
Reliable volatile change dropped when all history acked (#5606) (#5613)
eba45c7 
* Refs #22658: Regression test

Signed-off-by: Juanjo Garcia <[email protected]>

* Refs #22658: Fix bug

Signed-off-by: Juanjo Garcia <[email protected]>

* Refs #22658: corrected failing CI

Signed-off-by: Juanjo Garcia <[email protected]>

* Refs #22658: Included reviewer suggestions

Signed-off-by: Juanjo Garcia <[email protected]>

---------

Signed-off-by: Juanjo Garcia <[email protected]>
(cherry picked from commit 90790ce)

Co-authored-by: juanjo4936 <[email protected]>
EugenioCollado added a commit that referenced this pull request Feb 4, 2025
@mergify @juanjo4936 @EugenioCollado
Reliable volatile change dropped when all history acked (#5606) (#5615)
bc53ad5 
* Reliable volatile change dropped when all history acked  (#5606)

* Refs #22658: Regression test

Signed-off-by: Juanjo Garcia <[email protected]>

* Refs #22658: Fix bug

Signed-off-by: Juanjo Garcia <[email protected]>

* Refs #22658: corrected failing CI

Signed-off-by: Juanjo Garcia <[email protected]>

* Refs #22658: Included reviewer suggestions

Signed-off-by: Juanjo Garcia <[email protected]>

---------

Signed-off-by: Juanjo Garcia <[email protected]>
(cherry picked from commit 90790ce)

* Fix namespace

Signed-off-by: Eugenio Collado <[email protected]>

---------

Signed-off-by: Eugenio Collado <[email protected]>
Co-authored-by: juanjo4936 <[email protected]>
Co-authored-by: Eugenio Collado <[email protected]>
RookieCLY pushed a commit to RookieCLY/Fast-DDS that referenced this pull request Feb 6, 2025
@juanjo4936 @RookieCLY
Reliable volatile change dropped when all history acked (eProsima#5606)
1ba6439 
* Refs #22658: Regression test

Signed-off-by: Juanjo Garcia <[email protected]>

* Refs #22658: Fix bug

Signed-off-by: Juanjo Garcia <[email protected]>

* Refs #22658: corrected failing CI

Signed-off-by: Juanjo Garcia <[email protected]>

* Refs #22658: Included reviewer suggestions

Signed-off-by: Juanjo Garcia <[email protected]>

---------

Signed-off-by: Juanjo Garcia <[email protected]>
Signed-off-by: RookieCLY <[email protected]>
RookieCLY pushed a commit to RookieCLY/Fast-DDS that referenced this pull request Feb 6, 2025
@juanjo4936 @RookieCLY
Reliable volatile change dropped when all history acked (eProsima#5606)
cf629bb 
* Refs #22658: Regression test

Signed-off-by: Juanjo Garcia <[email protected]>

* Refs #22658: Fix bug

Signed-off-by: Juanjo Garcia <[email protected]>

* Refs #22658: corrected failing CI

Signed-off-by: Juanjo Garcia <[email protected]>

* Refs #22658: Included reviewer suggestions

Signed-off-by: Juanjo Garcia <[email protected]>

---------

Signed-off-by: Juanjo Garcia <[email protected]>
Signed-off-by: RookieCLY <[email protected]>
Javgilavi pushed a commit that referenced this pull request Feb 6, 2025
@mergify @juanjo4936
Reliable volatile change dropped when all history acked (#5606) (#5614)
6d8c1b6 
* Refs #22658: Regression test

Signed-off-by: Juanjo Garcia <[email protected]>

* Refs #22658: Fix bug

Signed-off-by: Juanjo Garcia <[email protected]>

* Refs #22658: corrected failing CI

Signed-off-by: Juanjo Garcia <[email protected]>

* Refs #22658: Included reviewer suggestions

Signed-off-by: Juanjo Garcia <[email protected]>

---------

Signed-off-by: Juanjo Garcia <[email protected]>
(cherry picked from commit 90790ce)

Co-authored-by: juanjo4936 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EugenioCollado EugenioCollado EugenioCollado approved these changes

@richiprosima richiprosima Awaiting requested review from richiprosima

Assignees
No one assigned
Labels
ci-pending PR which CI is running
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@juanjo4936 @EugenioCollado