Allow specifying a custom devmapper snapshot device on snapshot boot #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amohoste
changed the title
amohoste
force-pushed
the
v0.25_reference_custom_snap
branch
2 times, most recently
from
5e5df1a to
e322467
Compare
ustiugov
requested changes
Nov 26, 2021
amohoste
force-pushed
the
v0.25_reference_custom_snap
branch
from
e322467 to
9ea5ae5
Compare
|
Regarding the comments, I completely undid the commit introducing the transport_reset_event function, however I agree temporarily commenting the place where it is invoked is a better approach. That way we can reintroduce that function call when someone looks into how to fix the agent becoming unavailable. I have now commented out the place where the transport_reset_event function is invoked. |
ustiugov
requested changes
Nov 28, 2021
amohoste
force-pushed
the
v0.25_reference_custom_snap
branch
2 times, most recently
from
7f68758 to
d824d36
Compare
Signed-off-by: Amory Hoste <[email protected]>
amohoste
force-pushed
the
v0.25_reference_custom_snap
branch
from
d824d36 to
5deb8a6
Compare
|
lgtm |
amohoste
force-pushed
the
v0.25_reference_custom_snap
branch
from
89843c4 to
52890e5
Compare
Signed-off-by: Amory Hoste <[email protected]>
amohoste
force-pushed
the
v0.25_reference_custom_snap
branch
from
52890e5 to
9b375b6
Compare
ustiugov
requested changes
Apr 26, 2022
| @@ -69,11 +69,11 @@ | |||
| # would help with reproducible builds (in addition to pinning Cargo.lock) | |||
|
|
|||
| # Development container image (without tag) | |||
| DEVCTR_IMAGE_NO_TAG="docker.io/vhiveease/fcuvm_dev" | |||
| DEVCTR_IMAGE_NO_TAG="docker.io/amohoste/fcuvm_dev" | |||
There was a problem hiding this comment.
please fix, update the build image on vhiveease if necessary
|
|
||
| # Development container tag | ||
| #DEVCTR_IMAGE_TAG="v30" | ||
| DEVCTR_IMAGE_TAG="v16_upf" | ||
| DEVCTR_IMAGE_TAG="v30" |
There was a problem hiding this comment.
Suggested change
| DEVCTR_IMAGE_TAG="v30" | |
| DEVCTR_IMAGE_TAG="v30_upf" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the functionality to specify a custom devmapper snapshot block device that contains the container root filesystem contents. The content of this block device must be the exact filesystem contents present at the time the corresponding Firecracker snapshot was taken. Allowing to specify a custom snapshot block devices allows us to more efficiently manage snapshots along with the possibility to boot from a remote snapshot. Additionally, the transport_reset event introduced in v0.25.0 was also removed since this interfered with the ability to restore a snapshot due to the FC agent becoming unreachable.