Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from ppy:master #4

Open
wants to merge 10,000 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
10000 commits
Select commit Hold shift + click to select a range
3fc86f6
Fix mobile release dialog obstructed by the software keyboard
frenzibyte Jan 4, 2025
e15978c
Add test coverage of user deleting intro files
peppy Jan 4, 2025
72dfdac
Ensure intro files exist in storage
peppy Jan 4, 2025
37da72d
Reduce nesting slightly
peppy Jan 4, 2025
d6e73d7
Merge pull request #31414 from frenzibyte/fix-display
peppy Jan 4, 2025
448790a
Merge pull request #31386 from peppy/fix-applying-offset
smoogipoo Jan 6, 2025
4f1a6b4
Always show dialog when clicking supporter icon before opening browser
peppy Jan 6, 2025
ca9e163
Don't require track to be playing to fix test failures on some platforms
peppy Jan 6, 2025
3a4497a
Constrain range of usable characters in romanised metadata to ASCII only
bdach Jan 6, 2025
1ca28d7
Merge pull request #31433 from bdach/romanised-metadata-ascii-only
peppy Jan 6, 2025
e8dc09f
Reduce HitSampleInfo constants allocations
EVAST9919 Jan 6, 2025
791ca91
Fix allocations in updateSamplePointContractedState
EVAST9919 Jan 6, 2025
d35b308
Use cleaner array creation expression
EVAST9919 Jan 6, 2025
804fe00
Make `ProgramId` public
Susko3 Jan 6, 2025
56eec92
Register application capability with file extensions
Susko3 Jan 6, 2025
64843a5
Clear out old way of specifying default association
Susko3 Jan 6, 2025
31bf162
Register URI handler as ProgID and add that to Capabilities
Susko3 Jan 6, 2025
2381975
Clear out old protocol data when installing
Susko3 Jan 7, 2025
638128b
Merge pull request #31436 from EVAST9919/editor-alloc
smoogipoo Jan 7, 2025
77d9c95
Merge pull request #31306 from bdach/aspire-slider-breakage
smoogipoo Jan 7, 2025
01e9c0f
Merge pull request #31418 from peppy/intro-file-integrity
bdach Jan 7, 2025
1648f2e
Ensure slider is not selectable when body is not visible
peppy Jan 7, 2025
a0496c6
Refactor `StarRatingRangeDisplay` test to be more usable
peppy Jan 6, 2025
383fda7
Fix star range display looking a bit bad when changing opacity
peppy Jan 6, 2025
8d913e8
Fix multiple animation inconsistencies pointed out in review
peppy Jan 7, 2025
b8a10d9
Mark recommendation test as flaky
peppy Jan 7, 2025
51b62a6
Display notification on friend presence changes
smoogipoo Jan 7, 2025
3c03406
Add failing test
bdach Jan 7, 2025
a5036cd
Re-route editor tempo adjustment via `EditorClock` and remove it on g…
bdach Jan 7, 2025
275e8ce
Remove unused protected field
bdach Jan 7, 2025
45e0adc
Add config option
smoogipoo Jan 7, 2025
98bb723
Do not expose track directly in `EditorClock`
bdach Jan 7, 2025
8f4eafe
Fix combo properties multiple reassignments
EVAST9919 Jan 7, 2025
973f606
Add test coverage for expected behaviour
bdach Jan 7, 2025
c93b875
Force new combo on objects succeeding a break
bdach Jan 7, 2025
bda1c3f
Merge pull request #31388 from peppy/fix-reverse-arrow-animation
bdach Jan 7, 2025
d291889
Merge pull request #31390 from peppy/slider-end-suppress-fix
bdach Jan 7, 2025
5431a08
Merge pull request #31435 from peppy/star-range-display-quality
bdach Jan 7, 2025
d0a39a7
Merge pull request #31442 from peppy/supporter-button-always-warns
bdach Jan 7, 2025
18ff25b
Merge branch 'master' into upgrade-packages
peppy Jan 7, 2025
125d652
Update realm xmldoc references
peppy Jan 7, 2025
6f42b59
Upgrade more packages again
peppy Jan 7, 2025
d5f2bdf
Appease message pack new inspections
peppy Jan 7, 2025
22b4f40
Merge pull request #27920 from peppy/upgrade-packages
smoogipoo Jan 8, 2025
d04947d
Don't use `record`s they are ugly
peppy Jan 8, 2025
b628880
Change association localisation flow to make logical sense
peppy Jan 8, 2025
d9f0f0d
Merge branch 'master' into editor-storyboard-display-2
bdach Jan 8, 2025
f216c22
Merge pull request #31445 from bdach/reset-speed-on-test-play
peppy Jan 8, 2025
fbfda2e
Extend test coverage with combo index correctness checks
bdach Jan 8, 2025
7c70dc4
Only update combo information when any changes happened
bdach Jan 8, 2025
e7070bd
Merge pull request #31448 from bdach/automatic-new-combo-after-break
bdach Jan 8, 2025
ac19124
Add failing test
bdach Jan 8, 2025
9058fd9
Delete entire juice stream when only one vertex remains after deletin…
bdach Jan 8, 2025
87866d1
Enable NRT in test scene
bdach Jan 8, 2025
e131a6c
Add explicit `ToString()` to avoid sending `LocalisableString` to reg…
peppy Jan 8, 2025
5a20247
Select closest timing point every time the timing screen is changed to
bdach Jan 8, 2025
2e10f83
Merge pull request #31450 from peppy/association-manager-cleanup
peppy Jan 8, 2025
bcd35c8
Merge branch 'master' into editor-storyboard-display-2
bdach Jan 8, 2025
dc23534
Merge branch 'master' into show-in-windows-association-menus and adap…
Susko3 Jan 8, 2025
520a5e4
Merge pull request #31454 from bdach/select-closest-timing-point-on-e…
smoogipoo Jan 9, 2025
c72cb01
Merge pull request #31452 from bdach/delete-juice-stream-if-path-dege…
smoogipoo Jan 9, 2025
025f3db
Merge branch 'master' into show-in-windows-association-menus
peppy Jan 9, 2025
f4d83fe
Keep friend states when stopping watching global activity
smoogipoo Jan 9, 2025
2a7a3d9
Add test showing that rate adjustments cause discrepancies in replay …
peppy Jan 9, 2025
c8f72fd
Fix rate adjustments changing the spacing between replay frames
peppy Jan 9, 2025
0fe6b4b
Add reason for making test interactive-only
peppy Jan 9, 2025
26264d6
Merge pull request #31438 from Susko3/show-in-windows-association-menus
peppy Jan 9, 2025
7268b2e
Add separate path for friend presence notifications
smoogipoo Jan 9, 2025
074b743
Merge pull request #31459 from peppy/fix-replay-frame-separation
smoogipoo Jan 9, 2025
18f1d62
Fix juice stream placement blueprint being initially visually offset
bdach Jan 8, 2025
5c8ae6f
Simplify editor "ternary button" structure
bdach Jan 9, 2025
2133ac6
Merge pull request #31453 from bdach/fix-juice-stream-placement-offset
peppy Jan 9, 2025
253b9cb
Add new osu!stable registry ProgId
Susko3 Jan 9, 2025
38d95ab
Merge pull request #31462 from bdach/ternary-button-is-bad
smoogipoo Jan 10, 2025
0509623
Ignore realm `List<T>` type
peppy Jan 10, 2025
73adc4d
Merge pull request #31364 from bdach/editor-storyboard-display-2
peppy Jan 10, 2025
4819694
Add combo colour override control to editor
bdach Jan 9, 2025
0d9a342
Merge conditionals
bdach Jan 10, 2025
933f5db
Merge branch 'master' into new-combo-editor
bdach Jan 10, 2025
94ea003
Update game `ScrollContainer` usage in line with framework changes
peppy Jan 10, 2025
5e9a753
Add basic implementation of new beatmap carousel
peppy Jan 10, 2025
288be46
Add basic selection support
peppy Jan 10, 2025
ad04681
Add scroll position maintaining
peppy Jan 10, 2025
6fbab1b
Stop exposing `CarouselItem` externally
peppy Jan 10, 2025
cf55fe1
Generic type instead of raw `object`?
peppy Jan 10, 2025
fef8178
Merge branch 'master' into update-osu-stable-from-registry
Susko3 Jan 11, 2025
afb9999
Merge pull request #31481 from Susko3/update-osu-stable-from-registry
peppy Jan 11, 2025
83a2fe0
Update readme with updated mobile release information
peppy Jan 12, 2025
dfbc93c
Fix typo
peppy Jan 12, 2025
76e0958
Fix possible nullref in `handleIntent()`
Susko3 Jan 12, 2025
b0339a9
Create game as soon as possible
Susko3 Jan 13, 2025
fc069e0
Only show colour on new combo selector button if overridden
bdach Jan 13, 2025
8968ab1
Merge branch 'master' into fix-skin-editor-undo
bdach Jan 13, 2025
39a69d6
Adjust test to pass
bdach Jan 13, 2025
75d1fab
Merge pull request #30060 from peppy/fix-skin-editor-undo
peppy Jan 13, 2025
7761a0c
Add failing test coverage showing storyboard not being updated when d…
peppy Jan 14, 2025
77db355
Ensure storyboards are still updated even when dim is 100%
peppy Jan 14, 2025
2c57cd5
Update framework
peppy Jan 14, 2025
904a08a
Update textbox usage in line with framework changes
peppy Jan 14, 2025
3c913c9
Merge branch 'master' into colour-for-friend-lb
peppy Jan 14, 2025
8ffd254
Adjust initialisation code to start with combo colour picker hidden
bdach Jan 14, 2025
8211c4e
Merge branch 'master' into colorhax
bdach Jan 14, 2025
058ff8a
Make test class partial
bdach Jan 14, 2025
f6073d4
Ensure API starts up with `LocalUser` in correct state
peppy Jan 14, 2025
92cc45d
Merge branch 'text-input-properties' into scroll-container-double-pre…
bdach Jan 14, 2025
51c7c21
Simplify operations on local list
smoogipoo Jan 14, 2025
156207d
Remove unused using
smoogipoo Jan 14, 2025
55ae040
Ensure API state is `Connecting` immediately on startup when credenti…
peppy Jan 14, 2025
459577c
Merge pull request #31474 from peppy/scroll-container-double-precision
bdach Jan 14, 2025
b4d054f
Merge pull request #31444 from smoogipoo/friend-presence-2
peppy Jan 14, 2025
3ddff19
Fix potential nullref due to silly null handling and too much OOP
peppy Jan 14, 2025
8d41eda
Merge branch 'master' into beatmap-carousel-v2
peppy Jan 14, 2025
d97a327
Split out `BeatmapCarousel` classes and drop `V2` suffix
peppy Jan 14, 2025
b0c0c98
Refetch local metadata cache if corruption is detected
bdach Jan 14, 2025
7e8a80a
Add difficulty, artist and title sort examples
peppy Jan 14, 2025
31d7c6a
Merge branch 'master' into colour-for-friend-lb
Plextora Jan 14, 2025
1e45aa7
Merge pull request #31240 from Plextora/colour-for-friend-lb
smoogipoo Jan 14, 2025
cc8941a
Add animation and depth control
peppy Jan 14, 2025
d81735d
Merge pull request #31492 from Susko3/fix-nullref
smoogipoo Jan 14, 2025
900237c
Add loading overlay and refine filter flow
peppy Jan 14, 2025
f2b7984
Merge pull request #31507 from peppy/api-startup-user
smoogipoo Jan 14, 2025
3523a2f
Merge branch 'master' into api-startup-state
peppy Jan 14, 2025
91fa2e7
Revert name change
peppy Jan 14, 2025
e871f02
Fix inspections that don't show in rider
peppy Jan 14, 2025
0e20c0e
Merge pull request #31473 from bdach/colorhax
peppy Jan 14, 2025
ad14720
Merge pull request #31508 from peppy/api-startup-state
smoogipoo Jan 14, 2025
20108e3
Remove Status and Activity bindables from APIUser
smoogipoo Jan 14, 2025
b7a9b77
Make config the definitive status value
smoogipoo Jan 14, 2025
208824e
Add ability for cursor trail to spin
EVAST9919 Jan 14, 2025
7a6355d
Sync cursor trail rotation with the cursor
EVAST9919 Jan 14, 2025
57a9911
Apply beatmap offset on every beatmap set difficulty if they have the…
Rudicito Jan 15, 2025
ef7982f
Merge pull request #31446 from EVAST9919/new-combo-editor
peppy Jan 15, 2025
b9f3a1d
Merge pull request #31523 from Rudicito/apply-offset-when-same-audio
smoogipoo Jan 15, 2025
0b764e6
Fix substring of `GetHashCode` potentially failing
peppy Jan 15, 2025
614243f
Merge pull request #31506 from peppy/fix-storyboard-break-overhead
bdach Jan 15, 2025
6027947
Move animation handling to `Carousel` implementation to better handle…
peppy Jan 15, 2025
7ca3a6f
Clear Discord presence when logged out
smoogipoo Jan 15, 2025
e22dc09
Update framework
peppy Jan 15, 2025
582c518
Implement spectator list display
bdach Jan 14, 2025
43fc48a
Add client methods allowing users to be notified of who is watching them
bdach Jan 14, 2025
12b2631
Add a skinnable variant of spectator list & hook it up to online data
bdach Jan 14, 2025
99c7e16
Add skinnable spectator list to default skins
bdach Jan 15, 2025
2eb63e6
Simplify rotation sync with no clocks involved
EVAST9919 Jan 15, 2025
6008c31
Typo fix
shawwn Jan 16, 2025
93a0ecd
Merge pull request #31531 from shawwn/2025-01-15/patch
smoogipoo Jan 16, 2025
920648c
Minor refactorings and xmldoc additions
smoogipoo Jan 16, 2025
fe8389b
Add test
smoogipoo Jan 16, 2025
471180d
Merge pull request #31519 from EVAST9919/trail-rotate
smoogipoo Jan 16, 2025
b54d959
Expose as IBindable from IAPIProvider, writes via config
smoogipoo Jan 16, 2025
c1f0c47
Allow setting of DummyAPIAccess status
smoogipoo Jan 16, 2025
a4174a3
Add failing test coverage showing offset adjust is not limited correctly
peppy Jan 16, 2025
1d240eb
Fix gameplay limitations for adjusting offset not actually being applied
peppy Jan 16, 2025
cde8e7b
Fix idle/hover colour handling weirdness in `OsuHoverContainer`
peppy Jan 16, 2025
56dfe4a
Adjust test to work better when running in sequence
peppy Jan 16, 2025
996798d
Avoid list width changing when spectator count changes
peppy Jan 16, 2025
32906ae
Add gradient on final spectator if more than list capacity are displayed
peppy Jan 16, 2025
e472449
Adjust animations a bit
peppy Jan 16, 2025
8400726
Move bindables to OsuConfigManager & SessionStatics
smoogipoo Jan 16, 2025
6b921fc
Merge pull request #31471 from peppy/beatmap-carousel-v2
bdach Jan 16, 2025
56b450c
Remove setting for right-mouse scroll (make it always applicable)
peppy Jan 16, 2025
1c2621d
Add support to CarouselV2 for right mouse button scrolling
peppy Jan 16, 2025
48609d4
Bump NVika tool to 4.0.0
bdach Jan 16, 2025
a6057a9
Move absolute scroll support local to carousel and allow custom bindings
peppy Jan 16, 2025
70c81b1
Merge pull request #31534 from bdach/nvika-dotnet-8
bdach Jan 16, 2025
e3b780d
Merge branch 'master' into spectator-list-visuals
bdach Jan 16, 2025
81f5450
Fix potential index accounting mistake when creating spectator list w…
bdach Jan 16, 2025
0c54853
Merge branch 'spectator-list-visuals' into spectator-list-ready
bdach Jan 16, 2025
1f1e940
Restore virtual modifier to fix tests (and mark for posterity)
bdach Jan 16, 2025
5c799d7
Bind to playing state via `GameplayState` instead to fix more tests
bdach Jan 16, 2025
1949c01
Fix skin deserialisation test
bdach Jan 16, 2025
5fc277a
Seek in replay scaled by replay speed
Rudicito Jan 16, 2025
3272224
Merge pull request #31526 from bdach/spectator-list-visuals
peppy Jan 17, 2025
224f398
Fix test potentially false-negative due to realm write delays
peppy Jan 17, 2025
ae7e4be
Fix tests
smoogipoo Jan 17, 2025
5425d62
Merge branch 'master' into remove-status-from-apiuser
smoogipoo Jan 17, 2025
a51938f
Separate the local user state
smoogipoo Jan 17, 2025
ee9998d
Merge branch 'master' into spectator-list-ready
peppy Jan 17, 2025
79fff13
Merge branch 'master' into beatmap-carousel-v2-right-click-scroll
smoogipoo Jan 17, 2025
7d02676
Merge pull request #31533 from peppy/fix-gameplay-offset-adjust-limit…
bdach Jan 17, 2025
3bb4b0c
Rename fields from `State` to `Presence` when presence is involved
peppy Jan 17, 2025
311f08b
Update `TestMetadataClient` to correctly set local user state in line…
peppy Jan 17, 2025
41c603b
Fix double-retrieval of user presence from dictionary in online display
peppy Jan 17, 2025
88829d5
Merge pull request #31535 from peppy/beatmap-carousel-v2-right-click-…
smoogipoo Jan 17, 2025
f59762f
`Playing` -> `PlayingState`
peppy Jan 17, 2025
c8b38f0
Add note about the visibility logic because it tripped me up
peppy Jan 17, 2025
a8456ce
Merge pull request #31513 from smoogipoo/remove-status-from-apiuser
peppy Jan 17, 2025
a1c5fad
Add curvature to new carousel implementation
peppy Jan 15, 2025
54f9cb7
Add overlapping spacing support
peppy Jan 15, 2025
43b5462
Add required padding on either side of panels so selection can remain…
peppy Jan 15, 2025
b215073
Add completion marker to daily challenge profile counter
bdach Jan 17, 2025
a67a68c
Remove unnecessary masking spec
bdach Jan 17, 2025
3c4bfc0
Merge spectator list classes into one skinnable
bdach Jan 17, 2025
b79e937
Fix code quality
bdach Jan 17, 2025
ebca2e4
Implement precise movement tool
bdach Jan 17, 2025
ec1a473
Merge pull request #31542 from peppy/beatmap-carousel-v2-curvature
bdach Jan 17, 2025
e753e3e
Update framework (except android)
peppy Jan 17, 2025
cbbcf54
add warning text on acronym conflict
ILW8 Jan 18, 2025
72e1b29
Don't highlight friends' scores under beatmap's friend score leaderboard
CloneWith Jan 19, 2025
b6ce72b
Remove redundant ToArray() calls in Osu/ManiaHitObjectComposer
turbedi Jan 19, 2025
a6ca9ba
Display up to 2 decimal places in `MetronomeDisplay`
Jan 19, 2025
3532ce1
Olibomby insisted on it being like this so i concede
Jan 20, 2025
8f33b4c
Add comment
Jan 20, 2025
e386c9e
Apply snapping when pasting hitobjects
Jan 20, 2025
45e0d91
Adjust tests to worked with snapped start time
Jan 20, 2025
e098f60
Merge pull request #31576 from CloneWith/feature/highlight-friend
peppy Jan 20, 2025
525e16a
Fix one more new inspection in EAP 2025
peppy Jan 20, 2025
e3195e2
Adjust new line break warning to hint
peppy Jan 20, 2025
c4509bb
Merge pull request #31539 from Rudicito/seek-in-replay-scaled-by-repl…
peppy Jan 20, 2025
b5b407f
Knock some sense into daily challenge profile test scene
peppy Jan 20, 2025
04ba686
Add basic animation
peppy Jan 20, 2025
7fd4adc
Merge pull request #31583 from turbedi/cleanup
peppy Jan 20, 2025
a1bcdb0
Adjust code slightly
peppy Jan 20, 2025
da69547
Merge pull request #31553 from ILW8/add-tourney-acronym-warning
peppy Jan 20, 2025
dcdb8d1
Always select text when an editor slider-textbox is focused
peppy Jan 20, 2025
cf032e5
Merge pull request #31547 from bdach/editor/precise-move
peppy Jan 20, 2025
c20b836
Merge pull request #31543 from bdach/daily-challenge-completion-marker
peppy Jan 20, 2025
89586d5
Fix settings in replay hiding when dragging a slider
Rudicito Jan 20, 2025
2c5b438
Merge pull request #31593 from Rudicito/fix-player-settings-overlay-h…
smoogipoo Jan 21, 2025
46ff9d1
Fix beat snap grid being lines not being corectly centered to time
peppy Jan 21, 2025
748e631
Merge branch 'master' into ios-system-file-import
peppy Jan 21, 2025
afec5ba
Merge pull request #31602 from peppy/fix-taiko-beat-snap-grid
smoogipoo Jan 21, 2025
f133042
Fix silly mistake
frenzibyte Jan 21, 2025
a7c9f84
Adjust visuals slightly
peppy Jan 21, 2025
0a97fb6
Merge pull request #31586 from minetoblend/feature/metronome-decimals
peppy Jan 21, 2025
3f51626
Simplify code immensely
frenzibyte Jan 21, 2025
3a37817
Don't block `Popover` escape handling (just let it work in addition t…
peppy Jan 20, 2025
9a12f48
Fix `ComposeBlueprintContainer` handling nudge keys when it can't nudge
peppy Jan 20, 2025
aeca91c
Fix main menu osu logo being activated by function keys and escape
peppy Jan 20, 2025
b6e7b43
Remove unnecessary input blocking
peppy Jan 20, 2025
c8cc36e
Add failing test coverage of random rewind button not working
peppy Jan 21, 2025
66be9f2
Remove right click default for absolute scroll
peppy Jan 21, 2025
6c27e87
Add back explicit right click handling of carousel absolute scrolling
peppy Jan 21, 2025
704c2ea
Merge pull request #31026 from frenzibyte/ios-system-file-import
peppy Jan 21, 2025
0265a29
Move bindings to `LoadComplete()`
bdach Jan 21, 2025
8f82462
Merge pull request #31527 from bdach/spectator-list-ready
smoogipoo Jan 21, 2025
cc7c549
Add test scene for clipboard snapping
Jan 21, 2025
fde2b22
Add transient flag for notifications which shouldn't linger in history
peppy Jan 22, 2025
4cf4b8c
Switch `IsImportant` to `init` property isntead of `virtual`
peppy Jan 22, 2025
9e02334
Mark friend notifications as non-important
peppy Jan 22, 2025
910c002
Adjust code style slightly
peppy Jan 22, 2025
26ef23c
Remove outdated ef related catch-when usage
peppy Jan 22, 2025
631ae90
Merge pull request #31613 from peppy/friend-notifications-bug-less
smoogipoo Jan 22, 2025
2623d8d
Merge pull request #31604 from peppy/fix-song-select-right-click-hand…
bdach Jan 22, 2025
63e6b0e
Merge pull request #31603 from peppy/input-amendments
smoogipoo Jan 22, 2025
6ceb348
Adjust code again to avoid weird `throw` mishandling
peppy Jan 22, 2025
c94b8bf
Apply NRT to new class
peppy Jan 22, 2025
218720b
Merge pull request #31588 from minetoblend/feature/paste-snapped
peppy Jan 22, 2025
3da220b
Fix crash from new combo colour selector when there are no combo colo…
bdach Jan 22, 2025
11e84f3
Merge pull request #31616 from bdach/fix-new-combo-button-crash
smoogipoo Jan 22, 2025
bf23c67
Merge pull request #31509 from bdach/local-metadata-cache-corruption
peppy Jan 22, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Only update combo information when any changes happened
  • Loading branch information
bdach committed Jan 8, 2025
commit 7c70dc4dc305d7bcd421c0e1f8d83d1ab3bfd67b
19 changes: 14 additions & 5 deletions osu.Game/Screens/Edit/EditorBeatmapProcessor.cs
Original file line number Diff line number Diff line change
@@ -111,20 +111,29 @@ private void ensureNewComboAfterBreaks()

int currentBreak = 0;

for (int i = 0; i < Beatmap.HitObjects.Count; ++i)
{
var hitObject = Beatmap.HitObjects[i];
IHasComboInformation? lastObj = null;
bool comboInformationUpdateRequired = false;

foreach (var hitObject in Beatmap.HitObjects)
{
if (hitObject is not IHasComboInformation hasCombo)
continue;

if (currentBreak < breakEnds.Count && hitObject.StartTime >= breakEnds[currentBreak])
{
hasCombo.NewCombo = true;
if (!hasCombo.NewCombo)
{
hasCombo.NewCombo = true;
comboInformationUpdateRequired = true;
}

currentBreak += 1;
}

hasCombo.UpdateComboInformation(i > 0 ? Beatmap.HitObjects[i - 1] as IHasComboInformation : null);
if (comboInformationUpdateRequired)
hasCombo.UpdateComboInformation(lastObj);

lastObj = hasCombo;
}
}
}