Fixed xml deserialization for missing prefixes #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkhsjdhjs
suggested changes
Oct 5, 2022
There was a problem hiding this comment.
@otto-ifak I had a quick look at the change. Can you adjust it in accordance to the comments? Thanks!
| @@ -85,8 +85,9 @@ def _tag_replace_namespace(tag: str, nsmap: Dict[str, str]) -> str: | |||
| """ | |||
| split = tag.split("}") | |||
| for prefix, namespace in nsmap.items(): | |||
| if namespace == split[0][1:]: | |||
| return prefix + ":" + split[1] | |||
| if prefix: | |||
There was a problem hiding this comment.
Which value does prefix have when the prefix is missing? I would prefer an explicit check for that value (e.g. prefix is not None, if prefix were to be None when the prefix is missing).
s-heppner
reviewed
Jul 4, 2023
Comment on lines
88
to
89
| if prefix: | ||
| if namespace == split[0][1:]: |
There was a problem hiding this comment.
Suggested change
| if prefix: | |
| if namespace == split[0][1:]: | |
| if prefix and namespace == split[0][1:]: |
|
I just realized that we don't have the right to edit this PR :D |
|
@s-heppner Done. |
|
Perfect, thank you! |
s-heppner
pushed a commit
that referenced
this pull request
Aug 16, 2024
* adapter.http: implement the attachment routes * adapter.http: fix codestyle errors * adapter.http: implement recommended changes * adapter.http: implement new recommended changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The xml deserialization fails when xml tags without prefixes are used.