Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed xml deserialization for missing prefixes #33

Merged
merged 2 commits into from
Oct 3, 2023
Merged

Fixed xml deserialization for missing prefixes #33

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
639e9c9
Fixed xml deserialization for missing prefixes
otto-ifak Sep 7, 2022
915a3b7
Simplify condition
otto-ifak Sep 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions basyx/aas/adapter/xml/xml_deserialization.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,9 @@ def _tag_replace_namespace(tag: str, nsmap: Dict[str, str]) -> str:
"""
split = tag.split("}")
for prefix, namespace in nsmap.items():
if namespace == split[0][1:]:
return prefix + ":" + split[1]
if prefix:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which value does prefix have when the prefix is missing? I would prefer an explicit check for that value (e.g. prefix is not None, if prefix were to be None when the prefix is missing).

if namespace == split[0][1:]:
s-heppner marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if prefix:
if namespace == split[0][1:]:
if prefix and namespace == split[0][1:]:

return prefix + ":" + split[1]
return tag


Expand Down