Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

align advanced pub-sub with zenoh-c #370

Merged
merged 2 commits into from
Jan 15, 2025
Merged

align advanced pub-sub with zenoh-c #370

merged 2 commits into from
Jan 15, 2025

Conversation

DenisBiryukov91
Copy link
Contributor

align advanced pub-sub with zenoh-c;
bump zenoh-c;
bump zenoh-pico;

@DenisBiryukov91 DenisBiryukov91 added enhancement New feature or request api sync Synchronize API with other bindings labels Jan 15, 2025
milyin
milyin requested changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@milyin milyin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but with "optional" it becomes less clear what happens when 0 value is set. I think it's better to mention it

include/zenoh/api/ext/session_ext.hxx Show resolved Hide resolved
include/zenoh/api/ext/session_ext.hxx Show resolved Hide resolved
@milyin milyin merged commit b216284 into eclipse-zenoh:main Jan 15, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milyin milyin milyin requested changes

Assignees
No one assigned
Labels
api sync Synchronize API with other bindings enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DenisBiryukov91 @milyin