Fix arduino examples #650
Merged
Fix arduino examples #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR missing one of the required labels: {'dependencies', 'internal', 'bug', 'breaking-change', 'documentation', 'new feature', 'enhancement'} |
sashacmc
reviewed
Sep 12, 2024
| @@ -21,16 +21,12 @@ | |||
| #define SSID "SSID" | |||
| #define PASS "PASS" | |||
|
|
|||
| #define CLIENT_OR_PEER 0 // 0: Client mode; 1: Peer mode | |||
| #if CLIENT_OR_PEER == 0 | |||
There was a problem hiding this comment.
What's the reason for not using the CLIENT_OR_PEER approach?
There was a problem hiding this comment.
Basically the #if was ignored and compiler complained that #mode and #connect were redefined.
sashacmc
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #649 and brushes up the arduino examples a little.
The issue itself was due to owned_entities declared as local variables that went out of scope at the end of
setup()and were overwritten in theloop()phase, causing a segault.