Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add background declaration #652

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Add background declaration #652

merged 2 commits into from
Sep 12, 2024

Conversation

jean-roland
Copy link
Contributor

Closes #626.

Drop entity functions now clears up the memory without undeclaring.

@github-actions GitHub Actions
Copy link

PR missing one of the required labels: {'new feature', 'enhancement', 'bug', 'breaking-change', 'dependencies', 'internal', 'documentation'}

@jean-roland jean-roland added enhancement Things could work better api sync Synchronize API with other bindings labels Sep 12, 2024
@DenisBiryukov91
Copy link
Contributor

also need to update the docs
say that _drop does not drop the callback (that it will be done by session_drop/close)

milyin
milyin approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@milyin milyin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sashacmc will finish up this

@milyin milyin merged commit 4150752 into eclipse-zenoh:main Sep 12, 2024
54 of 55 checks passed
@milyin milyin mentioned this pull request Sep 12, 2024
Closed
28 tasks
@sashacmc sashacmc mentioned this pull request Sep 12, 2024
Merged
@jean-roland jean-roland deleted the ft_background_declaration branch October 8, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milyin milyin milyin approved these changes

Assignees
No one assigned
Labels
api sync Synchronize API with other bindings enhancement Things could work better
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add background declaration
3 participants
@jean-roland @DenisBiryukov91 @milyin