Merge pull request #901 from DenisBiryukov91/fix/ZRuntime_drop

fix ZRuntimePool drop crash if not all runtimes were initialized
eclipse-zenoh · Apr 4, 2024 · 1f8dbe4 · 1f8dbe4
2 parents 6799a92 + f419da8
commit 1f8dbe4
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/commons/zenoh-runtime/src/lib.rs b/commons/zenoh-runtime/src/lib.rs
@@ -154,12 +154,9 @@ impl Drop for ZRuntimePool {
         let handles: Vec<_> = self
             .0
             .drain()
-            .map(|(name, mut rt)| {
-                std::thread::spawn(move || {
-                    rt.take()
-                        .unwrap_or_else(|| panic!("ZRuntime {name:?} failed to shutdown."))
-                        .shutdown_timeout(Duration::from_secs(1))
-                })
+            .filter_map(|(_name, mut rt)| {
+                rt.take()
+                    .map(|r| std::thread::spawn(move || r.shutdown_timeout(Duration::from_secs(1))))
             })
             .collect();