Remove set_priority and set_congestion_control from publisher #1124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milyin
approved these changes
Jun 12, 2024
DariusIMP
added a commit
to ZettaScaleLabs/zenoh-kotlin
that referenced
this pull request
Jun 12, 2024
…nControl during runtime. Done after changes on Zenoh from eclipse-zenoh/zenoh#1124
DariusIMP
added a commit
to ZettaScaleLabs/zenoh-kotlin
that referenced
this pull request
Jun 12, 2024
…nControl during runtime. Done after changes on Zenoh from eclipse-zenoh/zenoh#1124
DariusIMP
added a commit
to ZettaScaleLabs/zenoh-kotlin
that referenced
this pull request
Jun 12, 2024
…nControl during runtime. Done after changes on Zenoh from eclipse-zenoh/zenoh#1124
OlivierHecart
pushed a commit
to eclipse-zenoh/zenoh-kotlin
that referenced
this pull request
Jun 12, 2024
… express config to publisher builder (#110) * issue(Publisher QoS): adding express config for the Publisher. * issue(Publisher QoS): removing publisher setPriority and setCongestionControl during runtime. Done after changes on Zenoh from eclipse-zenoh/zenoh#1124 * issue(Publisher QoS): refactoring publisher.rs on zenoh-jni
DariusIMP
added a commit
to ZettaScaleLabs/zenoh-kotlin
that referenced
this pull request
Aug 5, 2024
… express config to publisher builder (eclipse-zenoh#110) * issue(Publisher QoS): adding express config for the Publisher. * issue(Publisher QoS): removing publisher setPriority and setCongestionControl during runtime. Done after changes on Zenoh from eclipse-zenoh/zenoh#1124 * issue(Publisher QoS): refactoring publisher.rs on zenoh-jni
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A publisher is configured with all the necessary parameters at building time.
This allows Zenoh to know which parameters are going to be used for future publications and prepare the underlying infrastructure/network accordingly. By allowing to update the publisher parameters it becomes more difficult to prepare and/or pre-provision resources. Therefore, it is safer to remove the possibility in the API.