Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch 1 - Resolve typos at comment #1308

Closed
wants to merge 5 commits into from

Conversation

anhaabaete
Copy link
Contributor

Resolve typos at comment

When zenohd trying load file, if it have a problem it crash cause another treat was "unwrap", and it return to a type config. So, it crash and cause painic.
When tring load config file defined by -c option. With haver any problema "unwrap" has been to Config type.

I treat it return a Default Config whe it happen
If file fail when try load configs
Resolve typos at comment
@diogomatsubara
Copy link
Contributor

diogomatsubara commented Aug 19, 2024

@anhaabaete Thanks for your contribution. Could you adjust the target of the PR to eclipse-zenoh:main instead of eclipse-zenoh:master?

@fuzzypixelz fuzzypixelz changed the base branch from master to main September 2, 2024 07:24
@Mallets
Copy link
Member

Mallets commented Sep 10, 2024

It seems the majority of the changes initially proposed by this PR have already been fixed on main.
The latest change left is related to a portion of code that was considered incorrect and it was later removed.

@Mallets Mallets closed this Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants