Add advanced pub/sub last sample miss detection #1701
+329
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oteffahi
commented
Jan 10, 2025
Comment on lines
+990
to
+996
| // TODO: add state to avoid sending multiple queries for the same heartbeat if its periodicity is higher than the query response time | ||
|
|
||
| // check that it's not an old sn or a pending sample's sn | ||
| if (state.last_delivered.is_none() | ||
| || state.last_delivered.is_some_and(|sn| heartbeat_sn > sn)) | ||
| && !state.pending_samples.contains_key(&heartbeat_sn) | ||
| { |
There was a problem hiding this comment.
This TODO could be covered by not sending a query unless there are no pending queries (i.e no pending queries from heartbeat, periodic queries, or miss detection queries). Does that sound right @OlivierHecart ?
There was a problem hiding this comment.
Hypothetically speaking, doing so might risk that (in some potential high-load cases) heartbeats would get denied by other querying mechanisms and never result in a heartbeat query...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1657